Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps ark-vrf to 0.5.1 and uses the newly exposed
PcsVerifierParamsandverifier_key_from_commitmentto replace the byte-level recovery of the canonical KZG verifier key (ref davxy/ark-vrf#95)The pinning check in
validate/batch_validatenow rebuilds the verifier key from the members' own ring commitment plus the canonical params and compares structurally, dropping the serialization-layout assumption and its TODO.Reworks the
VerifierCache/ProverCachetraits: the Handle associated type is gone, methods return Cow<'static, _> and come with uncached default implementations, soNullCachereduces to empty impls. VerifierCache gains empty_members_set, and the Bandersnatch suite serves the empty-ring members set deserialized once per domain instead of on every start_members call.