Add test for offchain-worker#139
Open
naijauser wants to merge 18 commits into
Open
Conversation
rockbmb
added
enhancement
rockbmb
reviewed
Jul 13, 2026
rockbmb
left a comment
rockbmb
left a comment
Collaborator
There was a problem hiding this comment.
@naijauser can I ask you to squash these commits to clean up history? 18 for a relatively small PR is ⬆️😱
rockbmb
approved these changes
Jul 13, 2026
| use substrate_cli_test_utils as common; | ||
| use tokio::process::Command; | ||
|
|
||
| #[tokio::test] |
Collaborator
There was a problem hiding this comment.
This test is actually doing two separate things:
- testing the successful execution case
- testing the negative one as well
Now, I get that this is done to avoid having to spin up a process twice for what is essentially the same test (good decision); there's just a bit of clarity missing.
Could you write a top-level comment on the test like I asked you to do in PET? As usual, future selves will appreciate it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10