Fix required association fields - #229
Merged
nicolas-brousse merged 1 commit intoAug 4, 2026
Merged
Conversation
Member
|
Hi @Guflly thanks for you contribution. Tests are currently broken, I'll try to take time to fix this. Could you update the Changelog? |
Guflly
force-pushed
the
fix/association-required-fields
branch
from
July 31, 2026 12:40
560375e to
2218ee5
Compare
Contributor
Author
|
Added it under Unreleased. |
Member
|
@Guflly thanks, could you rebase to get the latest commit in |
nicolas-brousse
self-requested a review
July 31, 2026 13:24
Guflly
force-pushed
the
fix/association-required-fields
branch
from
July 31, 2026 14:24
2218ee5 to
ef90e67
Compare
Contributor
Author
|
Rebased onto the latest |
Member
|
Thank you for your contribution |
Member
|
This change has been published under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
object_method_nameswhen collecting validators, so required associations are detected for*_idand*_idsfields.Adds coverage for
belongs_toandhas_many.Closes #191