Skip to content

Fix Titan 2 Elite rounded corners - #298

Merged
pzauner merged 7 commits into
palsoftware:mainfrom
itsthisjustin:fix/titan2elite-rounded-corners
Sep 6, 2026
Merged

pzauner merged 7 commits into
palsoftware:mainfrom
itsthisjustin:fix/titan2elite-rounded-corners

Conversation

@itsthisjustin

@itsthisjustin itsthisjustin commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Improve the experimental Titan 2 Elite rounded-corner layout so the keyboard chrome follows the physical screen curves instead of cutting off controls and modifier indicators.

Changes

  • Nest status-bar controls inside the screen's bottom curves, using platform corner radii with a fallback for devices that do not report them.
  • Make suggestions and variations gapless in rounded mode, including dynamic variation sizing and theme-aware side and bottom fills. Empty side-button slots use the appropriate row background.
  • Resize side-button touch targets and center their icons for normal and Pastierina modes; improve clipboard count placement and readability.
  • Draw curved modifier indicators with consistent thickness and height. Remove duplicate disabled tracks and the gap between the right Ctrl and Shift indicators. Shared contours show the strongest active/locked modifier state.
  • Align SYM page heights, close-button geometry, and bottom fills; skip the panel slide animation in rounded mode.
  • Reuse the SYM close control for clipboard and emoji panels. Clipboard entries retain their individual card spacing and backgrounds.
  • Expand emoji category buttons to the bottom control-row height and center their icons. Let touches pass through the transparent portion of the overlapping indicator layer so search and category controls remain tappable.
  • Keep new surfaces and icons tied to keyboard theme colors, and restore the existing layout when the rounded-corner setting is disabled.

Refactor corner radius handling to apply rounded corners to the entire IME chrome layout instead of just padding the bottom row. Move corner radius logic from padding-based insets to ViewOutlineProvider-based clipping. Increase fallback corner radius from 24dp to 50dp for better visual consistency.
Conditionally disable vertical padding when Titan2 Elite rounded corner insets are enabled. Also optimize by only calling setPadding when values actually change, setting geometryChanged flag accordingly.
Conditionally removes corner radii, borders, padding, and spacing from status bar buttons, suggestion bar, and variation bar when the Titan2Elite rounded corner insets setting is enabled. This creates a seamless, gapless appearance across UI chrome elements.
Adjust indicator view height calculation to account for requested row height and add bottom inset. Extend side light paths to start from the top of the row when the row is taller than the minimum required height.
Conditionally adjust padding, spacing, margins, and styling of status bar elements based on rounded corner insets setting. Remove padding and borders when rounded corners are enabled, and adjust close button dimensions and positioning accordingly.
Ensure that the chrome height fully covers the surface bottom with no unused band remaining below the indicators in the nested status bar geometry test.
@pzauner

pzauner commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

thanks for the PR; will look into it. Had it on my list of properly doing rounded corners as the current implementation sucks either way.

was thinking about wider outside buttons with non centered icons or an outside padding and then some rounding following the curve of the screen

@itsthisjustin

Copy link
Copy Markdown
Contributor Author

thanks for the PR; will look into it. Had it on my list of properly doing rounded corners as the current implementation sucks either way.

was thinking about wider outside buttons with non centered icons or an outside padding and then some rounding following the curve of the screen

Here's a screenshotScreenshot_20260906-050425.png

@pzauner

pzauner commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Mint!

@pzauner
pzauner merged commit 4bffacc into palsoftware:main Sep 6, 2026
@pzauner

pzauner commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

image image

@itsthisjustin

Copy link
Copy Markdown
Contributor Author

Oh that looks dope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants