ASAP 401 Fix - #90
Open
zendoodles wants to merge 1 commit into
Open
Conversation
Member
|
This looks good to me -- it fixes a dependency issue that has been cropping up for lots of folks. |
Member
|
I guess I should actually TEST Butler with these updated packages, though... |
Member
|
When I run {
"name": "medidata-styleguide",
"version": "1.0.0",
"description": "Styleguide for Medidata.",
"main": "index.js",
"scripts": {
"butler": "node_modules/butler/node_modules/.bin/gulp --gulpfile node_modules/butler/Gulpfile.js",
"develop": "node_modules/butler/node_modules/.bin/gulp --gulpfile node_modules/butler/Gulpfile.js develop",
"test": "node_modules/butler/node_modules/.bin/gulp --gulpfile node_modules/butler/Gulpfile.js test",
"deploy": "node_modules/butler/node_modules/.bin/gulp --gulpfile node_modules/butler/Gulpfile.js spress-deploy"
},
"repository": {
"type": "git",
"url": "git+ssh://git@github.com/palantirnet/medidata-styleguide.git"
},
"author": "Palantir.net, Inc. <info@palantir.net>",
"license": "ISC",
"bugs": {
"url": "https://github.com/palantirnet/medidata-styleguide/issues"
},
"homepage": "https://github.com/palantirnet/medidata-styleguide#readme",
"dependencies": {
"butler": "git://github.com/palantirnet/butler.git#asap-404-fix"
}
}I get an error related to the 'ajv' module: Do I need to run this with a particular version of node? |
Member
|
... and when I re-shrinkwrap myself, the branch still doesn't install in a project. This is probably happening because the drupalbox is using a pretty old version of NodeJs. |
Contributor
|
@becw I've had no problem installing things on UMUS using this branch, and I'm not able to use it otherwise. Could you test again to see if you get the same error as above so we can try and get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates shrinkwrap to remove dependency on unavailable uberinternal repo.