fix: bind to 127.0.0.1 by default, add --host option - #13
Open
saherr1969 wants to merge 1 commit into
Open
Conversation
Fixes pajaydev#11. Previously the server listened on 0.0.0.0 (all interfaces) by default, exposing conversation history to the local network without the user's knowledge. This change defaults the listen address to 127.0.0.1 (localhost only) so the server is not accessible from other devices. Users who want network access can opt in with: kiro-history --host 0.0.0.0 Changes: - server/index.ts: startServer() accepts a hostname parameter, defaults to '127.0.0.1', passes it to @hono/node-server serve(). - server/cli.ts: Added --host <address> CLI option (default: 127.0.0.1). - README.md: Documented the --host option in the options table and added a usage example.
Contributor
Author
|
Hi @pajaydev — just checking in on this. Let me know if you'd like any changes. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11.
Previously the server listened on 0.0.0.0 (all interfaces) by default, exposing conversation history to the local network without the user's knowledge. This change defaults the listen address to 127.0.0.1 (localhost only) so the server is not accessible from other devices.
Users who want network access can opt in with:
kiro-history --host 0.0.0.0
Changes: