Skip to content

ci(pv): one repo-tree pv pass for contracts-cli tests, fixtures elsewhere (Refs #5914) - #5915

Merged
noahgift merged 2 commits into
mainfrom
fix/pv-test-fixtures-5914
Oct 22, 2026
Merged

noahgift merged 2 commits into
mainfrom
fix/pv-test-fixtures-5914

Conversation

@noahgift

@noahgift noahgift commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Option B from the #5914 quorum (receipt handoff/triage-quorum-5914-pvcpu-*.md).

  • New repo_tree_pv test binary: ONE debug pv lint contracts --format json (shared OnceLock) plus one pv extract --check. Sigma, relations, shapes (73 shapes / 42 plant violations), refines probe and the ev11 ratchet probe (baseline file unchanged) read their verdicts from that single report. Fragment 601-...cmd wires it into CI.
  • The five old repo-tree tests are removed from ont2b/ont4/ont4b/ont4e/ev11 (their fixture-based tests stay); the sigma gate-mode test lints one copied contract.
  • Mutation: shapes_n 73 -> 74 turns repo_tree_pv red.

Measured user CPU-s (debug, /usr/bin/time, sigma+relations+shapes+refines+ev11): 96.9 before, 48.6 after (46.7 repo_tree_pv + ~1.9 others).
Residual repo-tree runs not touched: ont4f, ont4c5 (already shared), ont6, cli_integration. #5893 also converts the shapes full-run test; the two overlap in ont4b_shapes_gate.rs (trivial conflict).

Gate content: needs non-author quorum + 2 seats + arbiter sign. Not armed.

keep-open: #5914 stays open until the residual repo-tree runs named above (ont4f, ont4c5, ont6, cli_integration) are converted.

🤖 Generated with Claude Code

…lsewhere (Refs #5914)

The sigma, relations, shapes, refines and ev11 tests each linted the whole
contracts/ tree in a debug pv (~28 CPU-s per run). The real tree is now linted
once, in repo_tree_pv, and each gate's verdict is read from that one report;
the remaining callers use fixtures. Measured user CPU of the five binaries:
96.9 s before, 48.6 s after.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

§13.11 rung 1 — quorum shadow verdict

S13-SHADOW pr=5915 head=f3633cf4e60a1dd44eceb7c31c5da69cd8d1a3b3 verdict=REFUSE class=Q1 arm_rc=1

Shadow mode: this records a verdict and merges nothing. A refusal
to arm is not a block (§13 adds zero rows to §7) — the pull request is
exactly as green as it was.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat aprender-triage-worker REQUEST-CHANGES @874bd790323b52c6a046339fa1ee93b42f52a5b1 — MUST: scripts/tree_reader_tests.txt not updated (check_tree_reader_tests.sh FAIL '> aprender-contracts-cli --test repo_tree_pv'; shards red); run 'bash scripts/check_tree_reader_tests.sh --update'. The explicit-test fragment 601 is wired but only the full tier runs it; the PR/merge-queue path runs this binary via tree_reader_tests.txt. SHOULD: restore witness.pc_reasoner=="fired" (refines) and extract's shapes_n==73 assertion dropped from the old tests. Verified OK: sigma/relations/shapes/refines/ev11/extract all otherwise covered; repo_tree_pv 6/6; mutants shapes_n 73->74 and baseline 129->130 turn it red. FYI #5893 edits the two removed the_full_run_computes_* fns (edit/delete conflict for whoever merges second).

…repo_tree_pv as a tree reader (Refs #5914)

The tree-reader registry now lists repo_tree_pv, so the quick tier runs it
wherever the replaced ont2b/ont4/ont4b/ont4e/ev11 repo-tree tests ran.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat tw-opus APPROVE @f3633cf4e60a1dd44eceb7c31c5da69cd8d1a3b3 — delta 874bd79->f3633cf4e6 (3 lines) resolves the prior RC: registry line added (check_tree_reader_tests PASS, 223 targets), pc_reasoner + extract shapes_n 73 restored; repo_tree_pv 6/6; ci_test_tier --filterset emits binary_id(aprender-contracts-cli::repo_tree_pv) so quick-tier part 2 runs it (fragment 601 = full tier only, no double run); ci_test_tier --self-test 121/0.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat tw-argon APPROVE @f3633cf4e60a1dd44eceb7c31c5da69cd8d1a3b3 — delta 874bd79->f3633cf4e6 (3 lines) resolves the prior RC: registry line added (check_tree_reader_tests PASS, 223 targets), pc_reasoner + extract shapes_n 73 restored; repo_tree_pv 6/6; ci_test_tier --filterset emits binary_id(aprender-contracts-cli::repo_tree_pv) so quick-tier part 2 runs it (fragment 601 = full tier only, no double run); ci_test_tier --self-test 121/0.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quorum 3/3 AGREED @f3633cf4e60a1dd44eceb7c31c5da69cd8d1a3b3 (opus, argon, own run as evidence). Gate content: arbiter-cop sign owed. Not armed.

@noahgift

Copy link
Copy Markdown
Member Author

Gate sign-off (arbiter-cop, non-author): SIGNED @ f3633cf

Checked on lambda-labs at 08:2xZ. No cargo build here (lambda-labs build freeze), so the test binary itself is proven by this PR's CI, not by me.

  • Scope: no change to workflows or CI skip/reuse logic. Only scripts/tree_reader_tests.txt gains one line. So no new path reports green without running (reuse-hole check: none).
  • Assertions carried over: each removed pv lint --gate X corpus test (sigma, relations, shapes, spec, ratchet, extract --check) has its asserts in repo_tree_pv.rs, read from one full pv lint run. That run must exit 0, and gate(name) asserts verdict == Pass per gate. pc_reasoner and shapes_n == 73 are restored at f3633cf.
  • Guards at head: check_tree_reader_tests.sh rc 0; ci_test_tier.sh --self-test 121/0; check_ci_draft_skip.sh --self-test rc 0.
  • Guards on head merged with origin/main: check_tree_reader_tests.sh rc 0; ci_test_tier.sh --self-test 121/0.
  • Filterset: --filterset aprender-contracts-cli:--test:repo_tree_pv emits binary_id(aprender-contracts-cli::repo_tree_pv).
  • Mutant: with the repo_tree_pv registry line deleted, check_tree_reader_tests.sh goes rc 1 ("drifted … > aprender-contracts-cli --test repo_tree_pv"). That is RED, as it should be.
  • Note (non-blocking): the per-gate --gate X CLI path is no longer run against the real corpus; only the full run is. If single-gate selection matters, cover it by a unit test.

The PR is BEHIND main: merge main in before arming.

@noahgift
noahgift enabled auto-merge October 22, 2026 08:27
@noahgift
noahgift added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 80201c1 Oct 22, 2026
38 of 40 checks passed
@noahgift
noahgift deleted the fix/pv-test-fixtures-5914 branch October 22, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant