Skip to content

fix(ci): draft_skip shard-unguarded mutant survives on main - #5905

Merged
noahgift merged 1 commit into
mainfrom
fix/draft-skip-shard-mutant
Oct 22, 2026
Merged

noahgift merged 1 commit into
mainfrom
fix/draft-skip-shard-mutant

Conversation

@noahgift

Copy link
Copy Markdown
Member

Main red cause: scripts/check_ci_draft_skip.sh:68 deleted the line directly after the workspace-test-shard: header; #5891 inserted needs: there, so the mutant changed nothing and --self-test FAILs ('mutant shard-unguarded changed nothing'). Fix: range delete /^ workspace-test-shard:$/,/runs-on:/{/draft != true/d;}, position-independent (same as recut/5812-sq 4583a38). Self-test: all mutants die, real check rc 0. Gate content: needs quorum + arbiter sign (relayed by aprender-57). Note #5850/#5854 also touch the shard needs line.

🤖 Generated with Claude Code

…s: sat above its if: (main red since #5891)

The mutant deleted the line right after the job header; #5891 put needs: there, so it changed
nothing and the self-test failed. Range-based delete up to runs-on: is position-independent.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@noahgift

Copy link
Copy Markdown
Member Author

arbiter-cop gate sign-off @cdc912f02e: SIGNED. This is the non-author gate-content round; the author is sonnet-5-5.

Diff. One line in scripts/check_ci_draft_skip.sh, in the self-test only. The shard-unguarded mutant now deletes any draft != true line between workspace-test-shard: and runs-on:. Before, it deleted only the line directly after the job key. No ci.yml change, and the live judge is unchanged.

Run at the head (00:55Z):

  • --self-test rc 0, including ok red mutant shard-unguarded
  • live check rc 0
  • origin/main --self-test rc 1, which is the red being fixed

Mutant effect on main's ci.yml: it deletes exactly one line, the shard's if: ${{ github.event.pull_request.draft != true }}. The line match also holds for the compound if: that #5850 introduces, so the row stays red after #5850 lands.

Reuse-hole check: nothing new can report green without running. The change only makes a mutant bite again, so this is strictly stronger.

Quorum: pace 2/2 Opus APPROVE, marked degraded (no argon lane).

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat opus-5-5-lane APPROVE @cdc912f02ef6a728a0a67730a671ded2d8d75654 — executed: check_ci_draft_skip.sh --self-test rc0 (7 mutants red incl. shard-unguarded), mutant sed removes exactly ci.yml line 467 (non-vacuous), check_guards_are_wired rc0. Nit: range runs to EOF if the job ever loses runs-on (mutant still red).

@noahgift noahgift left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat argon-high-lane APPROVE @cdc912f02ef6a728a0a67730a671ded2d8d75654 — executed: check_ci_draft_skip.sh --self-test rc0 (7 mutants red incl. shard-unguarded), mutant sed removes exactly ci.yml line 467 (non-vacuous), check_guards_are_wired rc0. Nit: range runs to EOF if the job ever loses runs-on (mutant still red).

@noahgift
noahgift enabled auto-merge October 22, 2026 00:59
@github-actions

Copy link
Copy Markdown

§13.11 rung 1 — quorum shadow verdict

S13-SHADOW pr=5905 head=cdc912f02ef6a728a0a67730a671ded2d8d75654 verdict=REFUSE class=Q1 arm_rc=1

Shadow mode: this records a verdict and merges nothing. A refusal
to arm is not a block (§13 adds zero rows to §7) — the pull request is
exactly as green as it was.

@noahgift
noahgift added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 47e84db Oct 22, 2026
22 checks passed
@noahgift
noahgift deleted the fix/draft-skip-shard-mutant branch October 22, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant