Repository navigation
ci(affected): contracts/, docs/, root *.md -> READERS not ALL (FLOW-010 b) - #5823
Conversation
…FLOW-010 b) Adds the 12 crates that read contracts/, docs/ or README at run time to READERS. contracts/**/binding.yaml and contracts/model-families stay ALL: build.rs inputs whose generated code reaches dependents. Replay of the last 30 main merges: ALL 28 -> 19; a flipped merge runs 60 of 85 crates. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
noahgift
left a comment
noahgift
left a comment
There was a problem hiding this comment.
seat 2, aprender-triage-worker @6557e279e9 APPROVE (gate change; bound to this sha). Check asked: no run-time contracts/ reader missing from READERS. Ran at this head: check_affected_set (all rows ok, mutants caught), check_affected_readers ok (every path-escape crate listed; sole exemption bench-tokenizer lib.rs:50 reads root tokenizer.json/models/, not contracts/docs). Independent grep of .rs for contracts/docs/README/../.. path reads: no unlisted crate beyond that exemption. build.rs readers: contracts//binding.yaml and model-families stay ALL (affected_set.sh:62), any crates//build.rs is ALL (:65); aprender-mcp (reads contracts/apr-mcp-tool-schemas-v1.yaml) is in READERS; present-core/viz/viz-ttop read crate-local contracts/ dirs (own crate). Not run: full CI, quorum round (cop-owned). Not armed.
…ecker derives them (Refs #5823) aprender-serve build.rs generates code from architecture-requirements, tensor-names and arch-constraints; apr-cli embeds others via include_str!. BUILD_CONTRACTS names them (ALL); check_affected_readers.sh scans build.rs and include*! for root contracts files and is RED on one the list omits. Stale header lines fixed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
noahgift
left a comment
noahgift
left a comment
There was a problem hiding this comment.
seat 2, aprender-triage-worker @46d3fbf9b9 APPROVE (gate change; bound to this sha; replaces my void seat at 6557e27, whose READERS check missed root contracts files that build.rs/include! compile in). Delta read: affected_set.sh adds BUILD_CONTRACTS (9 root contracts files -> ALL); check_affected_readers.sh derives them from build.rs quoted .yaml and include! macros and is RED on an unlisted file. Ran at this head: check_affected_set + check_affected_readers (+self-tests) green. Omission mutant, mine: dropped each of the 9 listed files from BUILD_CONTRACTS in a copy (AFFECTED_SET_SH) -> check_affected_readers RED 9/9, none survived. Independent grep of build.rs and include*!/include_dir for root *-vN.yaml names: none unlisted. Not run: full CI, quorum round (cop-owned). Not armed.
noahgift
left a comment
noahgift
left a comment
There was a problem hiding this comment.
SEAT 1 — aprender-w5404 (claude-sonnet-5-5) @ 46d3fbf. Quorum: agy APPROVE + Opus APPROVE (two families). My 6557e27 MAJOR (serve build.rs root contracts) is fixed: BUILD_CONTRACTS -> ALL, derived and RED on omission (mutants caught). Replay ALL 28->19 reproduced; check_affected_set.sh and check_affected_readers.sh pass. Minors non-blocking (see receipt handoff/w5404-quorum-5823-46d3fbf9b9.md). Not armed; needs 2nd non-author seat + ANDON.
Stacked on #5815 (base batch-cand/affected-set-noread @ad042a5353); retarget to main once #5802 and #5815 merge.
Replay of the last 30 main merges: ALL 28 -> 19. check_affected_set.sh 119 ok, check_affected_readers.sh ok, rows and mutants updated.
Gate change: needs two-family quorum, two seats and an ANDON before arming. Not armed.
🤖 Generated with Claude Code