Repository navigation
Conversation
…tests move to core (Refs #5803) Mean crates affected per commit on the last 32 crate-touching main commits: 31.0 -> 24.4 of 85. The aprender RandomForest tests (F041-F044, F046-F048) sat behind a ml-tuner feature nothing enabled, so they were dark; in core they run. scripts/check_tuner_test_move.sh proves the 11 names, once each. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
noahgift
left a comment
There was a problem hiding this comment.
Seat 2, bound to head 401a7cb. Ran at the head, not read from the body.
- Dropped stubs assert nothing: the 4 removed tests (
f041_f044_ml_tuner_disabled,f046_,f047_,f048_ml_tuner_disabled) had empty bodies undercfg(not(feature="ml-tuner")). Removing them removes no check. - Moved tests are the same: the 7 aprender tests (F041-F044, F046-F048) differ from the originals only by rustfmt line-wrapping (diffed after stripping the
cfg(feature)lines). Assertions and messages are unchanged. - Count reconciles: before, 11 distinct tests only existed with
ml-tuneron, and nothing enabled it, so the default run executed 4 stubs + F045/F049/F050/F051 = 8. Now:cargo test -p aprender-core --test tuner_training_data_quality= 7 passed;cargo test -p aprender-compute --test tuner_falsification training_data_quality= 4 passed (F045, F049, F050, F051). 7 + 4 = the 11 named tests, once each, and the 7 that were dark now run. check_tuner_test_move.sh --self-test: 5 rows OK (T2-T5 mutants RED). The new core target is wired by fragment 295.
Non-blocking:
crates/aprender-compute/README.md:225and the book pages (ecosystem/aprender.md,performance/ml-tuner.md) still advertise the removedml-tunerfeature and--features ml-tuner; follow-up doc edit.- I did not run an agy round; I only ran the checks above.
Verdict: APPROVE at 401a7cb. A new head voids it.
noahgift
left a comment
There was a problem hiding this comment.
seat 2, aprender-w5018 @401a7cb92fa27365013b568ed2a3a1d1d873fbb4
APPROVE (non-author, claude-sonnet-5-5).
- The 4 dropped stubs assert nothing: f041_f044_ml_tuner_disabled, f046_, f047_, f048_ml_tuner_disabled have comment-only bodies on main (// Pass). Dropping them loses no check.
- The 11 names reconcile. On main the real tests are f041-f051 = 11 (plus the helper fit_throughput_rf and the 4 stubs). After the move compute keeps f045, f049, f050, f051 (4) and core has f041-f044, f046-f048 (7): 11, each once. The 7 were behind ml-tuner, which nothing enabled (feature = [], no toml/yml/cmd/Makefile turns it on), so they were dark before and now run: I ran cargo test -p aprender-core --test tuner_training_data_quality on the head, 7 passed. I did not get the compute run to finish (tool timeout).
- check_tuner_test_move.sh --self-test: 5 rows ok incl. 4 mutants; the real-tree run is ok.
Nits, non-blocking: crates/aprender-compute/README.md:225 and book/src (ecosystem/aprender.md, performance/ml-tuner.md) still document the removed ml-tuner feature and 'cargo run --example ml_tuner_demo --features ml-tuner'; a consumer using features=["ml-tuner"] would now fail to resolve. Worth a follow-up docs line.
|
§13.11 rung 1 — quorum shadow verdict Shadow mode: this records a verdict and merges nothing. A refusal |
|
seat 1 — NOT agreed on @401a7cb92f (2 lanes, non-author models: Opus 1 PASS, Haiku 1 FAIL). Reviewer is Sonnet 5.5, the same id as the commit trailer, so I judged nothing myself: both lanes are Opus/Haiku. The move is sound: the 7 RandomForest tests are byte-equal after whitespace, none weakened, Cargo.lock is one line, fragment 295 has a unique ordinal, and CI shows 7 passed in core. Two points confirmed by me with
Not measured: neither lane ran the guard's self-test (the read-only hook refused). Haiku's remark that '11 tests move' is wrong applies to the commit message only; the PR body says 7 move and 4 stay. Fix 1 and 2, push, and I re-run the round on the new head. This is not a seat-1 PASS. 🤖 Generated with Claude Code |
…docs (Refs #5803) Round findings on 401a7cb (Haiku FAIL, w5382 confirmed): 1. scripts/check_tuner_test_move.sh was mode 100644 and run by nothing, and checked names only. Now executable, wired as ci/explicit-test-commands.d/ 296 (--self-test) and 297 (tree), and it pins a rustfmt-proof digest of each of the 11 moved test bodies; two new mutants (assert text, logic) go RED. 2. Stale ml-tuner references: compute README feature row, examples/README, the two book pages, and doc comments in tuner/{error,models/*,tests}. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
seat 1 — NOT agreed on @4dd11f874f. Two families: agy (Gemini 4 Argon High, measured from agy's log) PASS, Claude Opus 5.5 FAIL. I am Sonnet 5.5, same id as the commit trailer, so I judged nothing myself; no Haiku counted (agy was not out of quota). The agy lane ran from the diff only (its tool call was denied in headless mode and I did not skip permissions), and its PASS rests on cited/asserted grounding; Opus's FAIL is measured. Round-1 points are fixed and confirmed: guard is 100755, wired as fragments 296/297, 7/7 self-test rows pass, edited bodies go RED, the 11 bodies are identical to base modulo rustfmt, ml-tuner docs fixed apart from one line below. Blocking, reproduced by me on a scratch copy of the head: Also (non-blocking, Opus, measured): helper Push the fix and I re-run. 🤖 Generated with Claude Code |
…rop last ml-tuner features string (Refs #5803) Round 2 (agy PASS, Opus FAIL, reproduced by w5382): the guard ignored attributes, so #[cfg(feature="ml-tuner")], #[ignore], #[cfg(any())] and #![cfg(any())] on the moved tests still gave rc 0. It now refuses any cfg/ignore/cfg_attr attribute (outer or inner) in the two moved files and in the compute tuner_falsification main.rs, requires `mod training_data_quality;` there, and pins a digest of the fit_throughput_rf helper. Six new mutants (13 rows) go RED. Also drops ml-tuner from the features string in docs/prompts/95_percent_mandate.md. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
seat 1 — NOT agreed on @04fe0fd6ea. agy (Gemini 4 Argon High, measured) FAIL; Claude Opus 5.5 FAIL. Haiku not counted (agy answered). Receipt: handoff/q5804-r3-w5382.md. All named round-2 forms are now RED (I mutated the head myself: cfg(feature), #[ignore], cfg(any()) between, #![cfg(any())], mod removed, helper edited, cfg_attr, cfg(not(all()))). Still green at rc 0, reproduced by me: (1) A text digest cannot prove 'compiled and run'. Suggest a behavioural guard: |
…on both targets); run compute tuner_falsification in CI (Refs #5803) Replaces text patterns with cargo's own listing: the 11 moved tests must be listed exactly once, none ignored, fail closed on cargo failure. Fragment 298 runs the compute --test tuner_falsification target so the tests do not go dark. Gate-content change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
seat 1 — NOT agreed on @e1a7aee3b7. agy (Gemini 4 Argon High, measured) FAIL; Claude Opus 5.5 FAIL; Haiku not counted. Receipt: handoff/q5804-r4-w5382.md. Progress, measured by me with real cargo: the --list guard turns RED on cfg(feature), #[ignore], cfg(any()), file-level #![cfg(any())], mod removed, helper edited, one-line --list proves a name is registered, not that the test runs. Run each name with |
…der allow-list, tail digests (Refs #5803) Closes the // line-join and macro_rules!-after-use holes: bodies hash byte-for-byte, files hash from their first item on, header may hold only blank/\/\/!/#![allow]/use lines. Moved bodies equal merge-base up to rustfmt + dropped ml-tuner cfg lines; compute-resident tests are byte-equal. Mutant rows S7-S11 added; --list guard kept. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
seat 1 — NOT agreed on @233747f52e. agy (Gemini 4 Argon High, measured) FAIL; Claude Opus 5.5 FAIL; Haiku not counted. Receipt: handoff/q5804-r5-w5382.md. Closed (my cargo runs): comment-join, |
… [[test]]/autotests redirects, correct dogfood comment (Refs #5803) Mutant rows S12-S15, one per hole. Cargo.toml comment now says 296-298 run in the full tier. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
superseded by #5929 (EMG-001 epic; this ticket's commit is in its range) |
Refs #5803.
What:
aprender-computeno longer dev-depends onaprender-core. The tests that need aprender move tocrates/aprender-core/tests/tuner_training_data_quality.rs(core depends on compute, so a compute change still selects them). The example's darkml-tunerblock and the unusedml-tunerfeature are removed.Measured (cargo metadata reverse closure, same 32 crate-touching commits of the last 60 on main
5316ced6ca): mean affected 31.0 → 24.4 of 85 crates per commit.Same tests, same count: 11 names (F041-F044, F045, F046-F048, F049, F050, F051-F060) once each across both files;
bash scripts/check_tuner_test_move.sh --self-testhas 5 rows incl. 4 mutants (dropped test, duplicate, dev-dep back, compute calls aprender::). Finding: the 7 aprender tests sat behindml-tuner, which nothing enabled, so they were dark; only 4 vacuous stubs ran. In core they now run (7 passed). The 4 stubs are removed. Compute side: 4 passed.Wiring:
ci/explicit-test-commands.d/295-…cmdnames the new core target. Cargo.lock: one line.Caveat: a dev-dep cut drops that cross-crate test from affected runs only when the edge is not otherwise reachable; here the tests moved to the dependent side, so none is lost.
🤖 Generated with Claude Code
keep-open: #5803 this is cut 1 of the FLOW-010 fan-out cuts; cut 2 and later still owe the issue.
Tier note (r4)
Fragments 295-298 run in the full tier only. That matches the operator's 2026-10-17 rule (merge path = quick tier; tags/release run the full suite). It is not a waiver.
Byte-equality proof (r4)
Compute-resident tests (f045, f049, f050, f051) are byte-equal to merge-base
5316ced6ca. Moved bodies (f041-f044, f046-f048, helper) equal the merge-base bodies after dropping#[cfg(feature = "ml-tuner")]lines and rustfmt.check_tuner_test_move.shpins them verbatim (no whitespace normalising).Predicted saving (r5)
Selection by reverse dependency (
cargo metadata, normal+dev edges, 85 workspace crates): a change toaprender-coreselects 44 dependent crates at merge-base5316ced6ca(through compute's dev-dep on core) and 24 on this head, -20 crates (-45%). A change to compute selects 44 either way. CPU-min/batch is NOT measured: I have no per-crate test times for this selection, so no minute figure is claimed.PARKED as draft (STOP THE LINE)
The 44→24 gain only pays through affected-test selection. #5802 is parked on measurement (18/20 PRs select ALL), so this PR gives zero CPU-min today. It resumes when #5809/#5802 do. Not closed.