Repository navigation
Conversation
…s/a_li_bi.rs (#4700) The ALiBi doc in layers/scaled_rope.rs gave the slope as 2^(-8h/n), which puts slope 1.0 on head 0. The compiled layers/alibi.rs computes 2^(-8(h+1)/n), as Press et al. and llama.cpp do, and its own doc says the +1 is load-bearing (ce39f30). The doc now matches the code. layers/a_li_bi.rs is a dark file: no mod, include! or #[path] reaches it, and every fn it defines exists in the compiled alibi.rs, position_alibi_get.rs or scaled_rope.rs. #4700 asks for the doc fix to land in the commit that deletes it. Refs #4700 Agent: la-0.72b Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
§13.11 rung 1 — quorum shadow verdict Shadow mode: this records a verdict and merges nothing. A refusal |
noahgift
commented
Oct 12, 2026
noahgift
left a comment
Contributor
Author
There was a problem hiding this comment.
seat 1, la-0.72 APPROVE @ 46fa943
The scaled_rope doc now gives 2^(-8(h+1)/n), which matches compute_slopes in alibi.rs (unchanged). layers/a_li_bi.rs has no mod, include! or path reference and only duplicates an impl fragment, so deleting it is safe. CI green.
Receipt: review-la-0.72-5168-46fa943b38.md
noahgift
commented
Oct 12, 2026
noahgift
left a comment
Contributor
Author
There was a problem hiding this comment.
seat 2, aprender-78 APPROVE @ 46fa943
- The deleted layers/a_li_bi.rs is dark at this head. No include!/include_str!, #[path] or parent-module
modresolves to its exact path (checked by path resolution, not a suffix grep), and no non-Rust file names it. - The new scaled_rope.rs doc line, slope 2^(-8(h+1)/n), matches the compiled code in layers/alibi.rs (
exponent = -((i + 1) as f32) * ratio), so head 0 gets 2^(-8/n). - CI on this head: 10 success, 2 skipped.
noahgift
added this pull request to the merge queue
Oct 12, 2026
Any commits made after this event will not be merged.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 12, 2026
noahgift
added this pull request to the merge queue
Oct 12, 2026
Any commits made after this event will not be merged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crates/aprender-serve/src/layers/a_li_bi.rsis not compiled. Nomod,include!or#[path]names it. Its 354 lines are an older copy of theScaledRoPEmethods plus theALiBidoc block, and every fn in it has a compiled twin inscaled_rope.rs. Readers who land on it read code that never runs.layers/a_li_bi.rsALiBislope doc in the compiledscaled_rope.rs: for n heads (a power of 2), head h gets 2^(-8(h+1)/n), so head 0 carries 2^(-8/n), never 1.0. That is whatALiBi::compute_slopescomputesMeasured on
main812dbe3 plus this diff:cargo fmt --checkexits 0,cargo check -p aprender-serveexits 0,cargo test -p aprender-serve --lib alibipasses 38 of 38, andcheck_src_test_files_wired.shexits 0.crates/aprender-serve/.pmat-baseline.jsonstill lists the deleted path as a data row. No build or gate reads that row as a source file, so it is left alone here.Refs #4700
keep-open: #4700 tracks every dark source file in the tree, and this PR removes one of them.
🤖 Generated with Claude Code