Repository navigation
test(train): the models row test pins the row #5142 made, a dispatch is a night - #5166
Merged
Merged
Conversation
…is a night #5142 made a dispatched run on main count as the night, and changed the models row's event pattern to ^(schedule|workflow_dispatch)$. The row test still pinned ^schedule$ and expected the old behaviour, so the nightly train's own case table read 10/13. The pin, the two dispatch rows and the header now state the #5142 rule: the newest run on C is read, whether scheduled or dispatched. Mutant m2 is turned around to plant the old schedule-only pattern, and is killed by two rows. 13/13 rows, 5/5 mutants. Refs: #5165 Agent: aprender-cd Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
§13.11 rung 1 — quorum shadow verdict Shadow mode: this records a verdict and merges nothing. A refusal |
noahgift
commented
Oct 12, 2026
noahgift
left a comment
Contributor
Author
There was a problem hiding this comment.
Seat 2, aprender-w4664. Head ec912e8. VERDICT: APPROVE (posted as a comment, because a shared account cannot approve; void on any push)
Run on this head:
scripts/tests/models_lane_row_test.sh: 13/13 rows pass, rc 0. That includesnewer_dispatch_red_is_the_night(red, run 503) anddispatch_alone_is_the_night(green, run 503).scripts/tests/models_lane_row_test.sh --mutants: 5/5 mutants killed, rc 0. The new m2 plants the old schedule-only event pattern, and 2 rows break on it.- The pinned
ROWis byte-identical to the live row atscripts/release/nightly_train.sh:112, which is^(schedule|workflow_dispatch)$. So the test now pins the rule #5142 shipped, not the one that was there before it. - Main's
check_pr_closes_issue.shpasses on the PR body.
Read: the change is test-only and the header table matches the new behaviour rows. The rename and inversion of the two dispatch rows follow from #5142's rule. I have no findings.
noahgift
commented
Oct 12, 2026
noahgift
left a comment
Contributor
Author
There was a problem hiding this comment.
seat 1, aprender-78 APPROVE @ ec912e8
- The new byte pin matches the models row the nightly train carries on main: ^(schedule|workflow_dispatch)$;^models$.
- RED before: the parent's test, run against this tree, gives 10/13. row_is_pinned, planted_dispatch_never_reaches_verdict and dispatch_alone_is_not_measured break.
- GREEN at this head: 13/13 rows, rc 0. --mutants kills 5/5; the inverted m2 (the old schedule-only row) breaks 2 rows.
- This is a test-only diff, 8 lines in one file. The two renamed rows assert the rule #5142 set: a dispatched run on main counts as the night. No other row or threshold changes.
- CI on this head: 10 pass, 2 skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LAB fix for #5165: the nightly train's own case table read 10/13 because
scripts/tests/models_lane_row_test.shstill pinned the models row from before #5142.#5142 made a dispatched run on main count as the night, and changed the models row's event pattern from
^schedule$to^(schedule|workflow_dispatch)$. This PR updates the test to that rule:planted_dispatch_never_reaches_verdictbecomesnewer_dispatch_red_is_the_night: a dispatched red newer than the scheduled green is read, and is red;dispatch_alone_is_not_measuredbecomesdispatch_alone_is_the_night: green, from that run;Result: 13/13 rows, 5/5 mutants killed. Test-only change; LAB, not a merge or release gate.
Closes #5165
Refs: #5142
keep-open: #5142 -- merged PR cited as the source of the rule; nothing to close
ont-delta: none -- test-only change; no ontology term changes
🤖 Generated with Claude Code