Repository navigation
Conversation
…#4700 batch 1) Each file lies under crates/*/src and no package compiles it: no mod, #[path] or include! reaches it from a package root (26 in aprender-serve and aprender-graph packages, plus crates/aprender-test/src, a dir with a virtual manifest only). A compiled file holds the same code: 23 are byte-identical, and 4 are identical once // comments and whitespace are removed (aprender-serve generate/mock_model.rs, gpu/gguf_model_state.rs, quantize/avx2.rs, and aprender-test/src/generated_contracts.rs). Deleting them loses no code. 40,766 lines. Kept back: aprender-serve gguf/cuda/cache.rs, the 28th such twin. The dark gguf/cuda/loading.rs include!s it (loading.rs:347), so it leaves with loading.rs in a later batch and no deletion here leaves a dangling include!. Baseline rows that named a deleted file are removed: src_test_files_unwired_baseline.txt -10 (the #3809 guard fails on a stale entry), complexity_baseline.txt -2, claim_literal_baseline.txt -1. Left as they are: crates/aprender-serve/.pmat-baseline.json (a pmat 3.11.1 snapshot from 2026-04-03, untouched since the subtree merge, 54 of its rows name these files), and the evidence/, datasets/ and docs/audits/ rows, which record the past. How the set was found: docs/lookahead/0.73/orphan_census.py --pin 316dee2 (branch la-73/3999-runs-everywhere-drafts): 138 orphans, 27 of them with a twin, plus 1 twin in a dir with no package. References: git grep at 316dee2 for each file's repo path, its crate-relative path and its last two path components, and for any include!/#[path]/include_str!/ include_bytes! literal ending in its basename. Of the 5 basename hits, 4 resolve to other files that exist, and the fifth is loading.rs:347 above. No source, contract, script or test reads any deleted file. Checks on this branch (no cargo on this host; CI's workspace-test is the build proof): - scripts/check_src_test_files_wired.sh: OK, 32 baselined dark files (was 42); --self-test: all cases pass. - scripts/check_baseline_ratchets.sh: all 3 baselines "did not grow (N removed)". Its 2 FAIL rows are tool_version (this box has pmat 3.42.0, the rows were recorded under 3.41.1) and also hit the untouched cb200_baseline.txt. - scripts/check_no_claim_literals.sh: PASS. REPORT 2 stale entries, the same 2 as on main. Refs #4700 Re-cut onto current main by la-0.72b (E6 look-ahead) from la-0.73's f3a0a48; the same 27 deletions and 3 baseline row removals. Refs #4700 Agent: la-0.72b Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
§13.11 rung 1 — quorum shadow verdict Shadow mode: this records a verdict and merges nothing. A refusal |
noahgift
commented
Oct 12, 2026
noahgift
left a comment
Contributor
Author
There was a problem hiding this comment.
seat 1, la-0.72 APPROVE @ 1d9fd52
Checked each of the 27 deleted files: none has a mod, include! or path declaration in its parent module, cfg-gated ones included. The three baseline files lose only the rows of the deleted files. CI green.
Receipt: review-la-0.72-5163-1d9fd52e6f.md
noahgift
commented
Oct 12, 2026
noahgift
left a comment
Contributor
Author
There was a problem hiding this comment.
seat 2, aprender-78 APPROVE @ 1d9fd52
- All 27 deleted .rs files are dark at this head. For each one, no include!/include_str!, #[path] or parent-module
modresolves to its exact path, checked by path resolution. A loose suffix grep flagged 10, and every one resolved to a different file (e.g. gguf/loader.rs includes gguf/token.rs, not src/token.rs). - The three baseline files lose only the rows for the deleted files; no other row is loosened. The one remaining non-Rust mention is a historical evidence log.
- CI on this head: 10 success, 2 skipped.
noahgift
added this pull request to the merge queue
Oct 12, 2026
Any commits made after this event will not be merged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch 1 of #4700: delete 27
.rsfiles undercrates/*/srcthat no build compiles, each a copy of code a compiled file already holds. This re-cuts f3a0a48 onto currentmainwith the same deletions; 40,766 lines go.aprender-serve, for exampletoken.rs,qa_phase.rs, bothmock_model.rsandlayers/multi_head_attention.rsgenerated_contracts.rscopies inaprender-graphandaprender-test; the compiled copy inaprender-servestayssrc_test_files_unwired10,complexity2,claim_literal1). No row is added and no row for a surviving file changesWhy this is safe:
moddeclaration names any of the 27 files.include!or#[path]onmainresolves to any of them. I checked 1,798include!targets and 857 path targets, each resolved relative to its own file.main812dbe3 plus this commit, all of these exit 0:cargo check -p aprender-serve --all-targets, with and without--features cudacargo check -p aprender-graph --all-targetscheck_src_test_files_wired.shcheck_baseline_ratchets.shRefs #4700
keep-open: batch 1 of several; #4700 also covers the stale-file decisions (S6, decode event, fused QKV, contract checks, argmax, ALiBi doc) and widening the dark-file guard to the whole tree.
ont-delta: none this sweep deletes uncompiled files, and the known-red rows it drops name only those deleted files; no type, shape or reason changes.
🤖 Generated with Claude Code