Repository navigation
fix(nightly): ci-pending is asked again the same night, then ends RED (#5053) - #5054
Merged
Merged
Conversation
…#5053) Run 38016007449 gated main 2m after its push. workspace-test was still running, so the gate decided ci-pending, skipped every build and the run ended green. Nothing retried, and the nightly went 27h unbuilt. The gate now asks again for the same sha: 7 tries 20 min apart (2h). Still pending after the last try, the run's verdict step exits 1 with the reason. scripts/nightly_gate_retry.sh --self-test carries the planted ci-pending head (must end red), and both mutations (ci-pending -> 0, no retry loop) turn it red. Refs #5053 Agent: fleetbins Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…exit (#5053) Review lanes A and B both asked for this case in the table. Adding it showed that decide relied on set -e: called inside a command substitution, where bash drops errexit, it went on past a failing gate command. It now returns the failure explicitly. The case is pinned, and removing `|| return` turns it red. Refs #5053 Agent: fleetbins Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
§13.11 rung 1 — quorum shadow verdict Shadow mode: this records a verdict and merges nothing. A refusal |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 10, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 10, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5053
Defect. Nightly run 38016007449 gated
main2 minutes after a push.workspace-testwas still running, so the gate decidedci-pending, skipped every build and the run ended green. Nothing retried it, and the nightly went 27h unbuilt.Change.
scripts/nightly_gate_retry.sh:decide <tries> <wait> -- <gate cmd>asks the gate again while it answersci-pending, for the same sha.verdict <decision>is the run's exit status:built/reusedgive 0; anything else gives 1 with the reason.nightly.ymlgate step: 7 tries, 20 min apart (2h), with steptimeout-minutes: 150.verdict, soci-pendingafter the last retry is red, never green.Proof.
bash scripts/nightly_gate_retry.sh --self-test: 12/12, run by the gate's Case table step. It includes the planted case: a ci-pending head on every try endsci-pending, and its verdict is rc 1.verdict ci-pending -> 0|| returnAgent: fleetbins
🤖 Generated with Claude Code