Skip to content

test: cover load_qwen35_layers in aprender-serve/src/gguf/qwen35_load.rs #5678

Open

Description

@noahgift

Test-only ticket, estimated <=200 lines of test. Source: pmat query --coverage-gaps --rank-by impact --exclude-tests on coverage-nightly run 39080471983 (sha e6ab79f; CI runner paths rewritten to this checkout).

Function: load_qwen35_layers in crates/aprender-serve/src/gguf/qwen35_load.rs. Write tests that assert behaviour (not just no-panic) so the uncovered branches run; per the coverage+contracts rule add or strengthen the matching falsification line in the contract YAML and run pv validate. No unwrap, no new Python.
Falsifier (write FIRST): a test asserting a specific output of load_qwen35_layers per uncovered branch, shown failing when that branch is deleted or inverted, then passing.
Before starting: confirm on origin/main the function is still uncovered (pmat query "load_qwen35_layers" --coverage --uncovered-only) and that no branch or open PR carries this ticket's number.
Done when: the function's uncovered lines are executed by tests in cargo test -p <crate> --lib and the contract line is in.

Activity

  1. added this to the 0.73.0 milestone on Oct 18, 2026
  2. added
    ready<=200 lines, scoped, verified not done on origin/main; a worker may pull it
    on Oct 18, 2026
  3. noahgift commented on Oct 22, 2026

    @noahgift
    MemberAuthor

    Tracked in #5875 (triage 2026-10-22).

  4. noahgift commented on Oct 22, 2026

    @noahgift
    MemberAuthor

    tracked in #5968

  5. noahgift commented on Oct 25, 2026

    @noahgift
    MemberAuthor

    R4 triage parked and closed PR #5942 (EMG-001 flush epic 5875-p2-a v2 (4 tickets)). This ticket stays open and links it; re-cut or reopen the PR when rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ready<=200 lines, scoped, verified not done on origin/main; a worker may pull it

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions