Skip to content

apr finetune and LoRA adapters: correct loading, merging and CUDA training #5341

Closed as not planned

Description

@noahgift

Scope: Adapter handling in aprender-train: PEFT tensors read as f32 without a dtype check, merges that are wrong on partial matches or a missing lora_alpha, adapters that fail to load with only a warning, the hybrid GDN (Qwen3.5) architecture refused until modelled, LoRA training on CUDA, and the complexity debt in the CUDA instruct path.

Why it matters: A fine-tune that silently loads or merges the wrong weights produces a model that looks trained and is not.

Done when: apr finetune trains a LoRA on CUDA for Qwen3.5, the merged model matches the PEFT reference within tolerance for bf16/f16/f32 adapters, and any adapter that cannot be read is a hard error.

Epic: #4000. Folded under triage rule 7b (2026-10-14): each row below was its own issue, closed as not planned and kept here as a sub-ticket. Reopen an issue when its work starts or its PR opens.

Sub-tickets

Activity

  1. added this to the 0.72.0 milestone on Oct 14, 2026
  2. added
    bugSomething isn't working
    P2Medium priority
    on Oct 14, 2026
  3. modified the milestones: 0.72.0, backlog on Oct 14, 2026
  4. noahgift commented on Oct 15, 2026

    @noahgift
    MemberAuthor

    Folded in (cop batch 10:31Z): #4698 — each is now a checklist row of this master.

  5. noahgift commented on Oct 22, 2026

    @noahgift
    MemberAuthor

    Tracked in #4000 (triage 2026-10-22).

  6. noahgift commented on Oct 22, 2026

    @noahgift
    MemberAuthor

    tracked in #4000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Medium prioritybugSomething isn't working

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions