Skip to content

apr qa: every gate skipped reports "All QA gates passed" and exits 0 #5226

Closed as not planned

Description

@noahgift

Same class as #2876: a gate that answers empty input with PASS.

gates_pass in crates/apr-cli/src/commands/qa.rs is all(|g| g.passed || g.skipped). If every gate is skipped, it is true. The only lower bound is check_min_executed, and that returns true when --min-executed is unset, which is the CLI default. So apr qa m.gguf with every --skip-* flag prints "All QA gates passed (0 executed, N skipped)" and exits 0 (qa_gguf.rs summary).

No CI path depends on this: the model ladder re-judges skips itself. End users get a PASS that measured nothing.

This is a behaviour change, so it is kept out of the #2876 guard branch. Candidate fix: 0 executed gates is a FAIL by name unless the caller asks for it, plus a RED test row for the all-skipped case.

Refs #2876

Activity

  1. added this to the 0.71.0 milestone on Oct 12, 2026
  2. modified the milestones: 0.71.0, backlog on Oct 14, 2026
  3. noahgift commented on Oct 14, 2026

    @noahgift
    ContributorAuthor

    Folded into #2876 as a checklist row (TRIAGE-100, 2026-10-14): the open-ticket cap is 100, so this ticket is now tracked on that master and closed as not planned. Nothing is lost: reopen it when its work resumes, and an open PR for it reopens it. Pushed branch: fix/5226-qa-all-skipped.

    Agent: aprender-clerk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions