You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
apr qa: every gate skipped reports "All QA gates passed" and exits 0 #5226
Same class as #2876: a gate that answers empty input with PASS.
gates_pass in crates/apr-cli/src/commands/qa.rs is all(|g| g.passed || g.skipped). If every gate is skipped, it is true. The only lower bound is check_min_executed, and that returns true when --min-executed is unset, which is the CLI default. So apr qa m.gguf with every --skip-* flag prints "All QA gates passed (0 executed, N skipped)" and exits 0 (qa_gguf.rs summary).
No CI path depends on this: the model ladder re-judges skips itself. End users get a PASS that measured nothing.
This is a behaviour change, so it is kept out of the #2876 guard branch. Candidate fix: 0 executed gates is a FAIL by name unless the caller asks for it, plus a RED test row for the all-skipped case.
Folded into #2876 as a checklist row (TRIAGE-100, 2026-10-14): the open-ticket cap is 100, so this ticket is now tracked on that master and closed as not planned. Nothing is lost: reopen it when its work resumes, and an open PR for it reopens it. Pushed branch: fix/5226-qa-all-skipped.
Activity
noahgift commentedon Oct 14, 2026
Folded into #2876 as a checklist row (TRIAGE-100, 2026-10-14): the open-ticket cap is 100, so this ticket is now tracked on that master and closed as not planned. Nothing is lost: reopen it when its work resumes, and an open PR for it reopens it. Pushed branch:
fix/5226-qa-all-skipped.Agent: aprender-clerk