Repository navigation
LAB: apr-cli test-target clippy red on main (crux_f_17 unwraps, nf4_classifier unused mut) #5202
Closed as not planned
Description
cargo clippy -p apr-cli --lib --tests -- -D warnings is red on main (reported 2026-10-12):
crates/apr-cli/tests/falsification_crux_f_17.rs:unwrap()onjson!values (banned by.clippy.tomldisallowed-methods).crates/apr-cli/src/commands/nf4_classifier.rs(test module, ~line 273): alet mutclosure that needs nomut.
LAB, not GATE. No merge or release path lints apr-cli test targets:
sov.lint(ci/vendor/sovereign-ci.yml) runscargo clippy --all-targetsat the workspace root, which lints only the root facade package (nodefault-members).scripts/check_clippy_cuda.shlints-p apr-cli --features cudawithout--tests/--all-targets, so test code is not in it.scripts/check_clippy_feature_matrix.sh(toolchain-ceiling.yml, scheduled) uses--libonly.release_ready.shanddogfood.shclippy rows run at the root facade.- No required job sets
RUSTFLAGS=-D warningsfor an apr-cli test build.
Fix: replace the unwraps with expect("…") and drop the mut, then prove cargo clippy -p apr-cli --lib --tests -- -D warnings clean.
Activity
noahgift commentedon Oct 12, 2026
Owner: aprender-a7n. Fix on branch
fix/5202-apr-cli-test-clippy@ 12f199e (branch only; a PR waits for a slot).cargo clippy --keep-going -p apr-cli --lib --tests -- -D warningsunwrap()in a json!-header fileclippy::unwrap_usedcargo test -p apr-clion the 22 changed targetscargo test -p apr-cli --lib nf4_classifier143 test-setup
unwrap()→expect("<ID>: test setup"); 137json!sites covered by a file-levelallow(disallowed_methods)+deny(unwrap_used)pair (json! expands toto_value(..).unwrap(); unwrap_used skips external macros, so hand-written unwraps stay refused). LAB ticket: no gate change.noahgift commentedon Oct 14, 2026
Folded into #5309 as a checklist row (TRIAGE-100, 2026-10-14): the open-ticket cap is 100, so this ticket is now tracked on that master and closed as not planned. Nothing is lost: reopen it when its work resumes, and an open PR for it reopens it. Pushed branch:
fix/5202-apr-cli-test-clippy.Agent: aprender-clerk