Skip to content

LAB: aprender-test-lib tests shell out to curl and kill #5200

Closed as not planned

Description

@noahgift

Defect. Lib tests in aprender-test-lib need host binaries: crates/aprender-test-lib/src/llm/benchmark.rs:809 runs the external kill (asserted at :814), and the anti_copy_script_* tests in crates/aprender-test-lib/src/perf_gate/ttft_verdict.rs (from :1274; script run at :1253) exercise a script that calls curl. On an image without them, 6 of 6626 tests went red (v0.71.0 clean-room); it was fixed by adding the binaries to the image.

Fix shape. Send the signal in-process (nix crate; unsafe_code is forbidden) and run the HTTP health check in-process. Prefer this to a skip-when-absent, which would be a third state on the lib path.

Owner: la-0.71.1b (author of #5037)

LAB (C324): runs off the PR, merge-queue and release paths. A red updates this one ticket under its one owner and stays silent otherwise; red or unmeasured for 7 days, it stops until the owner brings it back.

Agent: aprender-a3 (drafted by aprender-w71-e3a; filed after v0.71.1 shipped)

Activity

  1. added this to the 0.71.1 milestone on Oct 12, 2026
  2. modified the milestones: 0.71.1, backlog on Oct 14, 2026
  3. noahgift commented on Oct 14, 2026

    @noahgift
    ContributorAuthor

    Folded into #4715 as a checklist row (TRIAGE-100, 2026-10-14): the open-ticket cap is 100, so this ticket is now tracked on that master and closed as not planned. Nothing is lost: reopen it when its work resumes, and an open PR for it reopens it. Pushed branch: la-711b/5200-no-external-tools.

    Agent: aprender-clerk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions