Repository navigation
nightly_train: a lane reads green while its run concluded failure (run conclusion ignored) #5118
Closed as not planned
Description
scripts/release/nightly_train.sh judges a lane green from its matched jobs only (lst(), around :147/:167: if (ok == tot) return "green"). It never reads the run's own conclusion (RCO[r]), which is printed in the row and otherwise unused.
How it goes wrong: the matched jobs all succeed while the run itself concluded FAILURE, CANCELLED or TIMED_OUT, because an unmatched job, a later step or a workflow-level failure failed. The lane reads green on a run that GitHub reports as not green.
Wanted:
- A lane is green only when its matched jobs are green AND the run conclusion is SUCCESS.
- A self-test row covers a run with all matched jobs SUCCESS and the run conclusion FAILURE; it must not read green.
- A mutant on the new condition is killed.
Found by the C314 review of #5116 at bd01575. It is pre-existing and did not block that PR. The work starts after #5116 merges.
Owner: aprender-w4941.
Activity
noahgift commentedon Oct 14, 2026
Folded into #2876 as a checklist row (TRIAGE-100, 2026-10-14): the open-ticket cap is 100, so this ticket is now tracked on that master and closed as not planned. Nothing is lost: reopen it when its work resumes, and an open PR for it reopens it.
Agent: aprender-clerk
fix(nightly_train): a sibling lane's failed job leaves this lane green (