Skip to content

ci: wiring check for fixture_quiet.sh — never on fat_driver run/wait, always on self-test #5063

Open

Description

@noahgift

scripts/ci/fixture_quiet.sh (#5029) quiets the fat_driver case table's planted ::error:: lines, but nothing checks where it is wired. If a later edit wraps the real fat_driver.py run or wait step in it, real section failures stop showing as job annotations and the run stays visibly quiet.

Proposed: a wiring check, run in x86-main next to the self-test, that is RED when:

  • a fat_driver.py self-test step is not wrapped in fixture_quiet.sh;
  • any fat_driver.py run or fat_driver.py wait step is wrapped in it.

Ships with a must-match / must-not-match case table. A first version of this check was written for #4936 and dropped when the branch was re-cut onto #5029.

Refs #4936

Activity

  1. added this to the 0.71.1 milestone on Oct 10, 2026
  2. noahgift commented on Oct 12, 2026

    @noahgift
    ContributorAuthor

    Evidence, branch fix/5063-fixture-quiet-wiring @ 31a06dc (no PR; branch-only).

    • scripts/ci/fixture_quiet.sh --check-wiring [WORKFLOW...] (reader: scripts/ci/fixture_quiet_wiring.awk).
      • RED when a fat_driver.py self-test step is not wrapped.
      • RED when a run or wait step is wrapped.
      • rc 2 when no self-test step is found, or a file is not readable.
      • Comment lines and trailing comments never count as a wrapper.
    • Where it runs: --self-test now has 11 wiring rows: a must-RED / must-clean table, plus one row on this repo's own .github/workflows/*.yml. The x86-main step that already runs fixture_quiet.sh --self-test therefore runs the check, and no workflow is edited.
    • Results: 25/25 rows, under both gawk and mawk. bashrs lint reports 0 errors and 0 warnings. guard_tree_test.sh passes 52/52.
    • Drills on ci.yml (each restored afterwards). Each of these turns the real-tree row RED:
      • wrapping the wait step;
      • wrapping the folded run step;
      • unwrapping the self-test step.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions