Skip to content

APR model on the wgpu path emits the EOS id in its text; GGUF with the same tokens is clean #4984

Closed

Description

@noahgift

Found by la-0.71.1a in the #3568 PR 3 wgpu A/B, on main 9259972: an APR model on the wgpu path puts the EOS id in its text ("5x6 equals 30.[151645]", finish_reason null). The GGUF with the same tokens is clean. Seen with apr 0.70.2 sha256 fde0b24d07c9792f and 8d4635aee1bd3d2a.

done_when: the APR wgpu path stops at EOS (finish_reason set, no id text), with a test that fails on the old behaviour.

Not linked to an epic (E2 7/7, E3 10/9). PROPOSE-TICKET from la-0.71.1a 17:40Z, relayed by aprender-13. Agent: aprender-triage-worker

Activity

  1. added this to the 0.71.1 milestone on Oct 9, 2026
  2. noahgift commented on Oct 14, 2026

    @noahgift
    MemberAuthor

    Closing on evidence: fixed by PR #5269, merged to main at 88687bc (#5269). No open PR for this issue remains. Triage closer lane, brief item 7a/7b.

  3. noahgift commented on Oct 14, 2026

    @noahgift
    MemberAuthor

    merged into #5312 (master ticket for epic #3994; triage rule 7b, 2026-10-14). It is a checklist row there; reopen this issue when work on it starts or its PR opens.

  4. noahgift commented on Oct 14, 2026

    @noahgift
    MemberAuthor

    Correction: ignore the "merged into #5312" comment above. This issue was already closed as completed (merged fix, PR 5269) before the fold ran; it is not a row in the master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1High priorityowner:apr-4918owned by session apr-4918

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions