Skip to content

Gate-change PRs: refuse merge without a recorded sign-off bound to the head sha #4815

Closed as not planned

Description

@noahgift

Problem

The rule: a PR that changes what a check accepts, stricter included, needs two reviewers who are not its author plus the maintainer's sign-off before it merges.
Nothing enforces it.

Plan

  1. Case table. Write down what counts as a gate change, by path and by content. Examples: contract thresholds, ratchet baselines, check scripts, workflow if: and needs: lines, release scripts.
    • Give it must-match and must-not-match rows.
    • Build the rows from the 17 PRs above and from known code-only PRs.
  2. The check. Classify a PR's three-dot diff with the table. For a gate change, refuse unless both of these hold:
    • a sign-off record names the PR's head sha;
    • two non-author review receipts are bound to that same sha.
  3. Red proof. Give each classifier row a planted mutant that turns it RED.
  4. Landing. It lands as a ratchet: non-blocking at first, blocking only after three green nights. Making it a required check is a ruleset change, which is the maintainer's call.

Activity

  1. added this to the backlog milestone on Oct 8, 2026
  2. noahgift commented on Oct 13, 2026

    @noahgift
    ContributorAuthor

    park proposal: parked, no merge-time check binding a sign-off to the head sha exists on main @7f9a15a52b (no matching script under scripts/, no commit referencing this issue). A new blocking check needs its own ruling and baseline first, so it waits.

  3. added
    parkedClosed over epic budget (APR-EPIC-001 rule 5). Reopen = pull.
    on Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    parkedClosed over epic budget (APR-EPIC-001 rule 5). Reopen = pull.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions