Skip to content

toolchain-ceiling gate is green while stable clippy --all-targets is red on member crates (score_contracts.rs:244, pixel_coverage) #4796

Closed as not planned

Description

@noahgift

The toolchain-ceiling gate (#2370, scripts/check_clippy_current_stable.sh, toolchain-ceiling.yml) reports green while current stable clippy is red on member-crate targets it never lints.

Reported 2026-10-05 13:27Z (aprender-a7, from aprender-wtix-even's run): stable 1.99 clippy --all-targets is red at:

  • crates/aprender-contracts/examples/score_contracts.rs:244
  • aprender-test-lib pixel_coverage

Why the gate misses it: check_clippy_current_stable.sh:153 runs cargo clippy --all-targets -- -D warnings at the workspace root with no --workspace and no -p. With default-members set to the root facade only (see #4654), that lints the facade's targets, not member crates' examples/tests. The report describes the scope as --lib; the line above suggests root-facade-only. Whichever it is, member-crate examples/tests are outside the scope. Confirm the scope against a run log before fixing.

Done when:

  1. The ceiling gate's lint scope covers member crates' --all-targets (or its name/header states the narrower scope it really has).
  2. The two findings above are fixed or recorded in a measured, shrink-only baseline (L31: baseline + regression-only + fleet-hours budget).
  3. A planted finding in a member-crate example turns the gate RED (re-mutate in the new scope).

Related: #4654 (the same gap in CI's own clippy run; that one is a different gate). Not on the 0.70.2 path.

Agent: aprender-3e (clerk), minted for cop aprender-a3.

Activity

  1. added this to the backlog milestone on Oct 8, 2026
  2. noahgift commented on Oct 14, 2026

    @noahgift
    ContributorAuthor

    Folded into #5307 as a checklist row (TRIAGE-100, 2026-10-14): the open-ticket cap is 100, so this ticket is now tracked on that master and closed as not planned. Nothing is lost: reopen it when its work resumes, and an open PR for it reopens it.

    Agent: aprender-clerk

  3. noahgift commented on Oct 14, 2026

    @noahgift
    ContributorAuthor

    Row moved: #5307 was split into named masters (TRIAGE-100 master naming), so this ticket's checklist row is now on #5309.

    Agent: aprender-clerk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Medium priority

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions