Repository navigation
aprender-train: InstructPipeline::from_pretrained only warns when the adapter cannot be read, then trains fresh adapters #4698
Description
Proposed by la-0.72 (cop inbox, 2026-10-04 07:27Z, PROPOSE-TICKET x3, item (2)). The whole line, verbatim:
07:27Z | la-0.72 | L2 | PROPOSE-TICKET x3 (aprender-train, R15a follow-ups, from draft 16): (1) load_adapter_peft reads every tensor as f32 with no dtype check and returns them in HashMap order, so on main a bf16/f16 adapter loads as half-length tensors; (2) InstructPipeline::from_pretrained only warns when the adapter file cannot be read, and trains fresh adapters; (3) pay down instruct try_init_cuda (cyclomatic 17, cognitive 41) and cuda_train_step (18/40); the pre-commit hook makes this a prerequisite of R15a C2b/C3.
Branch evidence: la-0.72's R15a draft 16; for (3) the paydown is pushed on r15a-c2b-paydown @ a74c951 (inbox 08:04Z: try_init_cuda 17/41 -> 6/11, cuda_train_step 18/40 -> 9/20).
Train 0.72, under epic #4000 (E5 0.72: Train What You Serve). Owner: la-0.72. Branches only until 0.72 opens (C277.7). Minted by the cop's clerk.
Activity
noahgift commentedon Oct 14, 2026
merged into #5314 (master ticket for epic #4000; triage rule 7b, 2026-10-14). It is a checklist row there; reopen this issue when work on it starts or its PR opens.
noahgift commentedon Oct 14, 2026
Moved: this sub-ticket is now a row in #5341 (apr finetune and LoRA adapters: correct loading, merging and CUDA training), split out of #5314 by theme.
fix(finetune): load_trained_adapter is pub(super) so its sibling test…
noahgift commentedon Oct 14, 2026
0.72 floor row, closed in error
test(finetune): the #4698 refusal test reaches the safetensors parser
1 remaining item
noahgift commentedon Oct 15, 2026
Reopened by the cop: this is a protected 0.72 floor row (handoff/protected-072-floor.txt), so it must not be folded. The 10:30Z fold was the cop's error. Its master link stays as a cross-ref.
noahgift commentedon Oct 18, 2026
Evidence (no code change needed), verified on origin/main d6ea1ec:
InstructPipeline::from_pretrainednow callsload_trained_adapter(crates/aprender-train/src/finetune/instruct_pipeline/constructors.rs:403), which maps aload_adapter_peftfailure toError::ConfigError("trained adapter '<path>' could not be read: ...")and propagates it with?; no adapter file means fresh adapters. Landed in 351a421 (#5377). Not closing: keep-open belongs to the operator's batch call.noahgift commentedon Oct 31, 2026
Folded into #4000 as a checkbox by the 0.73–0.76 triage (2026-10-31): open tickets capped at 100, 0.76.0 capped by releases left. Not abandoned: reopen when #4000 schedules it. Icebox policy: #6521.