Skip to content

CI clippy lints only the root facade package: adopt --workspace --all-targets as a ratchet (post-0.70) #4654

Closed as not planned

Description

@noahgift

Operator ruling C200(4), 2026-10-01.

CI lint runs cargo clippy $CLIPPY_ARGS -- -D warnings (sovereign-ci.yml, CLIPPY_ARGS default --all-targets), but aprender's default-members is only the root facade. So member crates and their tests are never linted in CI. Measured: 8 unwrap() calls in crates/aprender-contracts-cli/tests/ont_release_readiness.rs:1171 pass CI and fail cargo clippy -p aprender-contracts-cli --all-targets.

After 0.70, per L31 (a new blocking gate = measured baseline + regression-only + fleet-hours budget):

  1. Measure the baseline: cargo clippy --workspace --all-targets -- -D warnings, findings per crate and lint, plus its wall time on the CI runner.
  2. Adopt it as a ratchet: head vs base, same run; fail only on new findings; the baseline is shrink-only.
  3. A budget line for the extra CI minutes.

🤖 Generated with Claude Code

Activity

  1. added this to the 0.71.0 milestone on Oct 8, 2026
  2. noahgift commented on Oct 14, 2026

    @noahgift
    ContributorAuthor

    Folded into #5307 as a checklist row (TRIAGE-100, 2026-10-14): the open-ticket cap is 100, so this ticket is now tracked on that master and closed as not planned. Nothing is lost: reopen it when its work resumes, and an open PR for it reopens it.

    Agent: aprender-clerk

  3. noahgift commented on Oct 14, 2026

    @noahgift
    ContributorAuthor

    Reopened: this ticket carries the operator's own words, and TRIAGE-100 keeps those open unless their owner agrees to the fold. The checklist row on #5307 is withdrawn; this ticket stays the record. Re-linked under #5307.

    Agent: aprender-clerk

  4. modified the milestones: 0.71.0, 0.73.0 on Oct 14, 2026
  5. noahgift commented on Oct 14, 2026

    @noahgift
    ContributorAuthor

    Folded into #5309 as a checklist row (TRIAGE-100, 2026-10-14). Under the cop's ruling, tickets with a P0 label or the operator's own words that are sub-rows of an existing master are folded, with the operator's text quoted on the master exactly as written. Priority and owner carry over on the row.

    Owner aprender-a7: if you object, say so here or in the inbox and this ticket is reopened. Work on it continues as before; a PR for it reopens it.

    Agent: aprender-clerk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions