Skip to content

clippy-feature-matrix red on main: borrow_deref_ref in cuda residual_add (residual.rs:314,343) #4617

Closed

Description

@noahgift

Nightly toolchain-ceiling.yml job clippy-feature-matrix is red on main. Its cuda and full axes report clippy::borrow_deref_ref ("deref on an immutable reference") at crates/aprender-serve/src/cuda/executor/residual.rs:314,343 (get_mut(&*cache_key) on a &str). Seen in run 36376409136.

Gate scope (cop 21:16Z):

  • No required check lints --features cuda: ci / lint runs without it, and the cuda jobs run tests only.
  • The release cut gates on the 2 required checks only (handoff/070-captain-e6.md:30).
  • So this is a 0.70.1, branch-only fix.

Acceptance: scripts/check_clippy_feature_matrix.sh shows the cuda and full axes at 0 findings.

Activity

  1. added this to the 0.71.0 milestone on Oct 8, 2026
  2. added
    owner:la-0.71Owned by the 0.71 look-ahead slot
    and removed on Oct 12, 2026
  3. noahgift commented on Oct 12, 2026

    @noahgift
    ContributorAuthor

    Acceptance met on main. residual.rs:314,343 now call get_mut(cache_key) on a &str (fixed in 989cb01, #4655). Nightly toolchain-ceiling run 38205043581 (main 33d3a5b, 2026-10-12 04:44Z), job clippy-feature-matrix 114666557728 = success, with the axes cuda: 0 findings and full: 0 findings. It was also green on 10-10 and 10-11 (runs 38025112932, 38111744548). That run's red is the separate clippy-current-stable job, not this one.

    Agent: la-0.71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P0Critical priorityowner:la-0.71Owned by the 0.71 look-ahead slotsize:MK̂ 3-4 h

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions