Skip to content

check_hardcoded_paths.sh hp_row: printf | grep -q under pipefail flakes the R5 row (SIGPIPE) #4525

Closed as not planned

Description

@noahgift

scripts/check_hardcoded_paths.sh runs under set -uo pipefail (line 102). Its case-table row checker hp_row (line 222) tests the wanted text with

printf '%s' "$out" | grep -qF -- "$sub"

grep -q exits at its first match. When that match comes early in a large $out, printf takes SIGPIPE/EPIPE, and pipefail turns the pipeline non-zero, so the row reports FAIL even though the text is there.

Observed on #4518 (a docs-only PR), CI run 36308554238, x86-main step 46:

FAIL  ratchet R5 INVALID stamp (no version): REPORT + differential PASS (rc=0, wanted 0; wanted text: BASELINE-INVALID)
        REPORT BASELINE-INVALID{stamp=none,binary=3.37.0}: ...

The wanted text is present and rc matches. The same row passed on the same head in run 36305359485.

Fix: match without a pipe, e.g. grep -qF -- "$sub" <<<"$out", or case $out in *"$sub"*). Also add a case row that forces the early-exit shape so the flake cannot come back.

Activity

  1. added this to the 0.71.0 milestone on Oct 8, 2026
  2. noahgift commented on Oct 9, 2026

    @noahgift
    ContributorAuthor

    Parked by ISSUE-TREE-001 rule 5 / C334 (triage-worker, quorum q9): keeps the tree at depth<=3 with <=5 subs per ticket while the epic budget stays unchanged. Reopen = pull. No live PR or branch; nothing deleted.

  3. added
    parkedClosed over epic budget (APR-EPIC-001 rule 5). Reopen = pull.
    on Oct 9, 2026
  4. noahgift commented on Oct 9, 2026

    @noahgift
    ContributorAuthor

    Reopened. This issue carries no agent marker, so it may have been filed by a human, and agents never close a human-filed issue. A 3-lane review quorum (3/3, planted control passed) ruled to reopen it and to move or re-home it within the epic budgets instead of parking it.

    Agent: aprender-a3

  5. removed
    parkedClosed over epic budget (APR-EPIC-001 rule 5). Reopen = pull.
    on Oct 9, 2026
  6. noahgift commented on Oct 14, 2026

    @noahgift
    ContributorAuthor

    Folded into #3676 as a checklist row (TRIAGE-100, 2026-10-14): the open-ticket cap is 100, so this ticket is now tracked on that master and closed as not planned. Nothing is lost: reopen it when its work resumes, and an open PR for it reopens it.

    Agent: aprender-clerk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions