Repository navigation
cuda-unit clippy gate (#3636) does not run on apr-cli-only diffs — apr-cli is outside GPU_CRATES #4336
Description
The clippy --features cuda gate added for #3636 runs in the cuda-unit job, which is gated on gpu_touched. scripts/ci_gpu_touched.sh GPU_CRATES (spec row 67-C1) does not include crates/apr-cli, and 30 files there contain #[cfg(feature = "cuda")]. A PR touching only apr-cli's cuda code never runs the lint. (Found by the sonnet quorum lane on the #3636 gate.)
Options:
- (a) Add apr-cli to GPU_CRATES. This sends every apr-cli PR through gpu-quick and cuda-unit, a runner-cost increase and a change to 67-C1.
- (b) Add a separate apr-cli-touched output that runs only the clippy step. This needs a step-level
ifso the 18-minute test steps are skipped. - (c) Run check_clippy_cuda.sh in cuda-nightly.yml, which catches the gap within 24 hours.
Needs a runner-cost decision.
🤖 Generated with Claude Code
Activity
fix(#3636): restore trap keeps the backup when cp fails; name the apr…
ci(cuda-unit): lint apr-cli's cuda code on apr-cli-only diffs without…
test(ci_gpu_touched): row label no longer says cuda-unit fires ONLY o…
fix(batch): #4336 added 2 pipe-into-grep-q sites (64->66) and 2d1978a'…
noahgift commentedon Oct 12, 2026
evidence for close: #4655 / 989cb01 (on main), how checked:
scripts/ci_gpu_touched.shon main keepsapr-cliout ofGPU_CRATES(:49) and adds it asCUDA_LINT_CRATES="apr-cli"(:56), so an apr-cli-only diff now runs the cuda clippy lint.cuda_lint=1.noahgift commentedon Oct 12, 2026
Cop batch close (FLOW-004 drain, ≤43/d): fix verified on main — merged #4655 ; ancestor of origin/main: 989cb01 . Evidence: #4336 (comment)