Skip to content

Every [[bin]] --version prints the build SHA (shared build-sha), then #4189 nightly requires it #4219

Closed as not planned

Description

@noahgift

Follow-up to #4189 / PR #4206, by cop ruling (2026-09-24).

Today: only apr prints the commit (apr 0.69.0 (aa7c6ef03)). The other 25 buildable bins print <name> 0.69.0, measured at aa7c6ef (table on #4189). So the nightly binds each binary to its SHA through the manifest (green_sha + per-bin bin_sha256). --version is checked for rc 0 and the crate version only. A bin that prints a DIFFERENT SHA is already red (version-mismatch).

Ask:

  1. Add one shared build-sha source for all workspace bins, e.g. a small build-script helper crate or env!("APR_GIT_SHA") set by one build.rs pattern. Every [[bin]]'s --version then prints <name> <ver> (<sha>), with +no-git from tarball builds as apr does now.
  2. Then tighten scripts/nightly_manifest.py record: a bin with no SHA in --version goes red. The self-test row "pv prints no SHA -> version_sha null" flips to red.

Acceptance: the case table row flips, and a nightly run shows version_sha non-null for every tool.

Activity

  1. added this to the 0.70.0 milestone on Sep 24, 2026
  2. noahgift commented on Sep 25, 2026

    @noahgift
    MemberAuthor

    Status check (aprender-ea): both halves are written. The build-SHA bins are in batch/0.70.0 (444800f). The nightly half is in B2 #4427 scripts/nightly_manifest.py: record already turns a bin with no SHA red (version-no-sha), and the self-test row for pv has flipped to red (lines 481/489/516). What remains is for #4427 to merge, then one nightly run showing non-null version_sha for every tool. No new code is needed.

  3. noahgift commented on Sep 25, 2026

    @noahgift
    MemberAuthor

    Part 1 evidenced at car/0.70.0 (#4429) head 93aa211e8: all 29 bin targets print <name> 0.69.3 (93aa211e8) on --version (release build, table on #4189 #4189 (comment)). Remaining: #4427 merge + one nightly with non-null version_sha for every tool.

  4. 1 remaining item

  5. noahgift commented on Sep 25, 2026

    @noahgift
    MemberAuthor

    Parked by APR-EPIC-001: over E1 budget (rank 46/93). Reopen = pull. Applied by aprender-d1: claude+agy both said close, apr shadow row recorded (handoff/close-quorum-2026-09-25.json).

  6. modified the milestones: 0.70.0, backlog on Sep 25, 2026
  7. added
    parkedClosed over epic budget (APR-EPIC-001 rule 5). Reopen = pull.
    on Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    parkedClosed over epic budget (APR-EPIC-001 rule 5). Reopen = pull.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions