Skip to content

aprender-serve published tarball: tokenizer_tests_unk_3609 include_bytes! tests/fixtures, which Cargo.toml excludes (/tests/) #4193

Closed as not planned

Description

@noahgift

Part of #4175. Found in aprender-3a's clean-room run on v0.69.1 (d8a6df5).

Test-only. The published lib is fine: the failing kind is lib test.

crates/aprender-serve/src/tokenizer_tests_unk_3609.rs (#3609, a #[cfg(test)] module) does include_bytes!("../tests/fixtures/gguf-header-slices/{qwen3.5-0.8b,tinyllama-1.1b-chat}.gguf-header"). crates/aprender-serve/Cargo.toml has exclude = [ …, "/tests/", … ], so cargo package drops the fixtures and the lib test cannot compile out of tree:

src/tokenizer_tests_unk_3609.rs:18:5: error: couldn't read `pkgs/aprender-serve-0.69.1/src/../tests/fixtures/gguf-header-slices/qwen3.5-0.8b.gguf-header`
src/tokenizer_tests_unk_3609.rs:20:5: error: couldn't read `pkgs/aprender-serve-0.69.1/src/../tests/fixtures/gguf-header-slices/tinyllama-1.1b-chat.gguf-header`

This is not #4048: that ticket is the contracts/kernel-fusion-v1.yaml include in fusion_call_site_guard_3985.rs, the third error in the same target.

Fix (pick one, in the #4175 review): (a) move the two header slices plus MANIFEST/generate.py under src/fixtures/gguf-header-slices/, the pattern src/fixtures/chat_template_3990/ already uses; the slices are small and ship with the crate. Or (b) the #4183 helper with a skip out of tree. (a) keeps the test running for crates.io users; check the slice sizes against the crate size budget first.

done_when: cargo build -p aprender-serve --lib --tests from the unpacked tarball has no error at tokenizer_tests_unk_3609.rs, and the #3609 rows still pass in tree.

Activity

  1. added this to the 0.70.0 milestone on Sep 24, 2026
  2. added
    kind:codeWork is a code change (derived rule, #4159)
    on Sep 24, 2026
  3. added a commit that references this issue on Sep 24, 2026
  4. modified the milestones: 0.70.0, 0.71.0 on Oct 4, 2026
  5. added
    P1High priority
    and removed
    P0Critical priority
    on Oct 14, 2026
  6. noahgift commented on Oct 14, 2026

    @noahgift
    ContributorAuthor

    P0 to P1 (2026-10-14 P0 triage): P0 now means it blocks the next release or carries the operator's own words on it; this issue does neither, so it stays on the 0.71.0 milestone at P1.

  7. noahgift commented on Oct 14, 2026

    @noahgift
    ContributorAuthor

    Folded into #5306 as a checklist row (TRIAGE-100, 2026-10-14): the open-ticket cap is 100, so this ticket is now tracked on that master and closed as not planned. Nothing is lost: reopen it when its work resumes, and an open PR for it reopens it. Pushed branch: fix/4193-on-070.

    Agent: aprender-clerk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1High prioritykind:codeWork is a code change (derived rule, #4159)owner:aprender-a7owner sessionsize:MK̂ 3-4 h

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions