Repository navigation
clippy -D warnings fails on aprender-serve on main (1280 excessive_precision in IQ tables, 5 deny-level undocumented unsafe) — no gate lints it: Makefile clippy is facade-only and serve doesn't inherit workspace lints #4152
Description
Measured 2026-09-24 on lambda, toolchain 1.93.0 (the pin), with #3606's branch at 9f60249. Every file listed is byte-identical to main (49fe19c), so this is main's state:
cargo clippy -p aprender-serve -p apr-cli --all-targets --no-deps -- -D warnings fails with:
- 1280 ×
clippy::excessive_precision, incrates/aprender-serve/src/quantize/{iq2_s,iq2_xxs,iq3_s,iq3_xxs,iq4_xs,iq_grids}.rs(the IQ grid tables). - 5 ×
clippy::undocumented_unsafe_blocks, which this crate sets todeny, so it is an error even without-D warnings:crates/aprender-serve/src/memory.rs:344:26crates/aprender-serve/tests/falsification_tests.rs:229:20crates/aprender-serve/tests/falsification_tests.rs:248:9crates/aprender-serve/tests/falsification_tests.rs:284:13crates/aprender-serve/tests/falsification_tests.rs:303:9
- other lints in
src/lib.rs,src/format_detect.rs,src/api/tests/cancel_scope_2376.rs(all byte-identical to main).
Why no gate sees it
- Scope. The Makefile's clippy gates (
Makefile:161,230,246:cargo clippy -- -D warnings) lint the ROOT FACADE package only. CLAUDE.md warns about exactly this ("Barecargo clippyonly lints the ROOT FACADE package, which is nearly empty"). - Lint table.
crates/aprender-serve/Cargo.tomldeclares its own[lints.clippy](undocumented_unsafe_blocks = "deny") and has no[lints] workspace = true. So the workspace'sexcessive_precision = "allow"(Cargo.toml:536, "ML test data needs precise values") never reaches it. The IQ tables are exactly the data that allow was written for.
Done when
cargo clippy -p aprender-serve --all-targets --no-deps -- -D warningsexits 0 on main. That means either aprender-serve inherits the workspace lints (keeping itsdenyfor unsafe blocks) or it allowsexcessive_precisionlocally, and the 5 unsafe blocks get// SAFETY:comments.- A gate lints every workspace member, not the facade. It gets a first-green proof on main, and a planted undocumented
unsafe {}in aprender-serve must turn it RED.
Found while adopting #3606 (aprender-30); filed at the cop's (aprender-cf) request.
Activity
fix(b1): clear the six fold defects #4311's CI named
fix(b1): guard-tree — a guard run by an explicit-test-command fragmen…
fix(serve): simd_axpy check required avx2 only for an avx2+fma fn; do…
Merge #4152 serve lint/soundness fixes + #4351 lean_has_sorry complex…
noahgift commentedon Sep 25, 2026
Status (aprender-a2):
batch/0.70.0@4c50f7277:crates/aprender-serve/tests/falsification_tests.rs, thesimd_axpycall guarded a#[target_feature(enable = "avx2,fma")]function withis_x86_feature_detected!("avx2")only, which is UB on a CPU that has avx2 but not fma. It now checks both.undocumented_unsafe_blocks.#[allow]on the five iq* ggml%.9ereference consts. The values are exact in f32 and stay byte-for-byte diffable against ggml. ACargo.toml [lints]allow does not work here, because the crate-level#![deny(clippy::all)]overrides it.fd5ec460eonPMAT-4152-clippy-ratchet:scripts/check_clippy_members.shkeys findings as<pkg>/<kind>:<target>/<lint>against a shrink-only baseline (scripts/clippy_members_baseline.txt,keyedin check_baseline_ratchets). The baseline has 102 keys and 3277 findings, pinned to rustc 1.93.0.--fulllints the whole workspace.needless_returnplanted in aprender-build-sha it goes RED. Measured locally: both pass.compare()used awk'sNR == FNR, which is also true on the current file when the baseline is empty, so a clean package could never go RED. It now usesFILENAME == ARGV[1].clippy-membersjob inguards-nightly.yml. A cold workspace clippy takes about 20 min on lambda, and guards-nightly already runs 32–55 of its 60 min. guard-cargo is at its budget, so PR-path wiring waits until the job has been measured on a runner.fix(guard): clippy-members self-test compared one path to itself; no-…
noahgift commentedon Oct 14, 2026
Folded into #5307 as a checklist row (TRIAGE-100, 2026-10-14): the open-ticket cap is 100, so this ticket is now tracked on that master and closed as not planned. Nothing is lost: reopen it when its work resumes, and an open PR for it reopens it. Pushed branch:
evidence/4152-serve-clippy-green,PMAT-4152-clippy-ratchet.Agent: aprender-clerk
noahgift commentedon Oct 14, 2026
Row moved: #5307 was split into named masters (TRIAGE-100 master naming), so this ticket's checklist row is now on #5331.
Agent: aprender-clerk