Repository navigation
contracts/binding.yaml: apr-model-graph-v1 forward_pass_completeness claims implemented, but fn forward_pass does not exist (ghost binding) #4094
Description
Found by PVL-001 EV-2 (#4080, branch PMAT-4080-pvl-2-ghost-binding-reject), which makes pv proof-status --binding resolve bindings and reject ghosts.
contracts/binding.yaml (lines ~477-482) claims:
- contract: apr-model-graph-v1.yaml
equation: forward_pass_completeness
module_path: aprender::inference::forward
function: forward_pass
status: implementedNo fn forward_pass exists anywhere in the tree (rg -n 'fn forward_pass\b' --type rust crates src finds nothing, 2026-09-23). With the EV-2 resolver:
pv proof-status --binding contracts/binding.yaml → rc=1
GHOST BINDINGS (1)
apr-model-graph-v1.yaml forward_pass_completeness: forward_pass
(The only other ghost the old resolver reported, compute_mse, was a false positive: it's pub(super) fn in crates/aprender-core/src/tree/regression_helpers.rs:27, and EV-2 fixes the resolver to see it.)
Fix: point the binding at the real forward-pass function(s), or set status to what is true (partial/not_implemented). No workflow calls proof-status --binding today, so nothing turns red yet, but any certification that does will reject until this is fixed.
Activity
noahgift commentedon Sep 23, 2026
Five more genuine ghosts, in
contracts/aprender/binding.yaml, found by the same EV-2 resolver once its source-root derivation stopped assuming the pre-monorepo layout. Each was checked withrg -n --type rust "(fn|struct|enum|type|trait) <name>\b" crates src→ NOT FOUND:swap_axesvalidate_element_countmap_tensor_namebidirectional_attentionmint_test_tokenTwo other names the old resolver flagged there,
SetFitArtifactDocandClassifyResponse, are realpub structs. EV-2 makes the resolver see type items, so they are no longer reported.noahgift commentedon Sep 24, 2026
triage 2026-09-24 (aprender-dd, issues owner; proposal #4159, approved by the cop aprender-cf): milestoned to 0.74.0 — unmilestoned tooling → carry to 0.74.0 (lightest of 0.71–0.74; its debt-ratchet slice). It was (no milestone). Open PR / live branch: PR#4095.
noahgift commentedon Sep 24, 2026
triage 2026-09-24 (aprender-dd; #4159, cop ruling): moved 0.74.0 → backlog. It has no release theme or epic, and operator rule 2026-09-24: "tickets go without an epic" to backlog, "no stray tickets allowed". It had been load-balanced into 0.74.0 as tooling carry earlier today.
fix(bindings): #4319 — 21 ghost bindings rebound to the item that imp…
noahgift commentedon Sep 25, 2026
Landed on batch/0.70.0 @ 68d46b7: the ghost
aprender::inference::forward::forward_passis rebound torealizar::ggufOwnedQuantizedModel::forward(pub, forward_fused_q4k.rs:17) with its signature. Codomain gap noted: it returns last-position [V], not [B,S,V]. pv validate: 0 errors; aprender-contracts lib: 1773 passed.noahgift commentedon Oct 12, 2026
evidence for close: 989cb01 (#4655), ancestor of main 6bd89b0. Checked at main: contracts/binding.yaml:477-482 binds forward_pass_completeness to OwnedQuantizedModel::forward in realizar::gguf::inference::forward::core. That function exists (forward_fused_q4k.rs, include!d from core.rs via forward_cached.rs). The extra ghosts named in the comments are not_implemented or removed.
noahgift commentedon Oct 12, 2026
Cop batch close (FLOW-004 drain, ≤43/d): fix verified on main — merged #4655 ; ancestor of origin/main: 989cb01 . Evidence: #4094 (comment)