Skip to content

Release T-4 does not wait for the tag's coverage run — a COV_FLOOR breach on the tag reds a run but does not stop the cascade (#3676 follow-up) #3690

Closed as not planned

Description

@noahgift

#3676 (PR #3688) takes ci / coverage off the PR/queue/push path, per the operator: "YES, coverage on tags release only". coverage-nightly.yml now also runs on every v* tag and enforces COV_FLOOR through make coverage. Nothing on the release path waits for that run. scripts/release/autopilot.sh goes tag → clean-room → assets → preflight → cascade. A floor breach reds the tag's coverage run, but the crates.io cascade proceeds anyway.

The pre-publish dogfood's make coverage-check still measures coverage before the tag, so a regression is not unguarded. The gap is that the tag's own run is recorded and never consulted. #3676's done_when says "a planted coverage drop fails the tag". Today that holds for the run, not for the release.

Deliberately not done in #3688, because it changes the release path and #3688 was built on the 0.69 cut day.

What lands

  • autopilot.sh: after the tag, find the coverage-nightly.yml run for refs/tags/<T>, the way the step already waits for the clean-room run, and require conclusion == success before dryrun/cascade. Absent after the wait, or not success, is a die naming the run.
  • A case-table row: a stubbed gh run list returning a failed tag coverage run stops the autopilot before the cascade; a missing run stops it too, because Unknown is not a pass.

Refs #3676 #3688 #3618

Activity

  1. added this to the 0.70.0 milestone on Sep 21, 2026
  2. added
    bugSomething isn't working
    kind:codeWork is a code change (derived rule, #4159)
    on Sep 21, 2026
  3. modified the milestones: 0.70.0, 0.70.1 on Sep 25, 2026
  4. noahgift commented on Sep 25, 2026

    @noahgift
    MemberAuthor

    Moved 0.70.0 → 0.70.1 per the cop ruling on the 0.70.0 burndown (aprender-77, 2026-09-25). This issue is not on the critical path of any 0.70.0 gate (ONT-001, all [[bin]]s #4189, discharge --strict, merge-back #4338). Burndown: /mnt/nvme-raid0/cop-inbox/aprender-ea-070-burndown.md — aprender-ea

  5. noahgift commented on Sep 25, 2026

    @noahgift
    MemberAuthor

    Status check (aprender-ea, 12:1xZ 2026-09-25): implemented on batch/0.70.0 by 51b3f2b (+665b67f14 #4352). autopilot.sh step 5 runs scripts/release/tag_coverage_gate.sh "$T" "$MC" before preflight and dies on rc≠0. --self-test PASS on the batch tip, including the rows "a COV_FLOOR breach stops the release" and "a missing run stops it too (Unknown is not a pass)". Closes when #4372 lands.

  6. noahgift commented on Sep 25, 2026

    @noahgift
    MemberAuthor

    Parked by APR-EPIC-001: over S1 budget (rank 68/163). Reopen = pull. Applied by aprender-d1: claude+agy both said close, apr shadow row recorded (handoff/close-quorum-2026-09-25.json).

  7. modified the milestones: 0.70.1, backlog on Sep 25, 2026
  8. added
    parkedClosed over epic budget (APR-EPIC-001 rule 5). Reopen = pull.
    on Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingkind:codeWork is a code change (derived rule, #4159)parkedClosed over epic budget (APR-EPIC-001 rule 5). Reopen = pull.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions