Skip to content

release/lib_release_params.sh: release_state_root silently falls back to the tree root when git fails — release state can split across two directories #3684

Closed as not planned

Description

@noahgift

Found in the #3682 sibling sweep (0.69 batch #3669).

scripts/release/lib_release_params.sh:39, release_state_root():
common=$(git -C "$root" rev-parse --path-format=absolute --git-common-dir 2>/dev/null) || common="". When git fails, the state root silently becomes the tree itself instead of the main checkout. From a worktree, the release train's AP (<state_root>/target/release-train/<tag>) then points at a different directory than the one the rest of the train uses, and files such as cleanroom-run-id are written in one place and looked for in another. It fails later (publish_strict.sh dies on a missing run id), but far from the cause and with no mention of git.

It runs on hosts (the autopilot), not in the docker runners, so it is lower risk than #3682. It is the same "a git failure becomes a plausible answer" class.

done_when

  • A git failure in release_state_root is an error naming git (rc 2), not a fallback. The fallback to $root applies only when git answered and the common dir is not */.git.
  • A case row with a PATH git stub that exits 128 gives rc 2 naming git.

Refs #3682 #3669 #3655

Activity

  1. added this to the 0.70.0 milestone on Sep 21, 2026
  2. added
    kind:codeWork is a code change (derived rule, #4159)
    on Sep 24, 2026
  3. modified the milestones: 0.70.0, backlog on Sep 24, 2026
  4. noahgift commented on Sep 25, 2026

    @noahgift
    MemberAuthor

    Parked by APR-EPIC-001: over S1 budget (rank 130/163). Reopen = pull. Applied by aprender-d1: claude+agy both said close, apr shadow row recorded (handoff/close-quorum-2026-09-25.json).

  5. added
    parkedClosed over epic budget (APR-EPIC-001 rule 5). Reopen = pull.
    on Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingkind:codeWork is a code change (derived rule, #4159)parkedClosed over epic budget (APR-EPIC-001 rule 5). Reopen = pull.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions