Skip to content

PP-QUANT-001 Q2 (core + compute + other crates): retype the boundary — raw u32 qtype → GgmlType; ratchet 3 files → 0 #3440

Closed as not planned

Description

@noahgift

Parent: #3421 · Slot: 0.70.0, after M1+M2 (ratcheted: if it does not fit the train, the remainder rides the next tag with a slipped_from: note).
Mechanism: core GgmlType (12 ids, the import path) and compute GgmlType (15) become re-exports in M1; this ticket retypes their consumers and audits the 14 further Quant*/Quantization* enums (cbtop, core, cuda-edge, qa-runner, registry, train, serve/testing) — each is either a different concept (keep, say why) or a fifth copy (delete).
Fix: parse u32 → GgmlType once at the loader boundary; everything downstream matches exhaustively on the enum. One PR for this directory only.
Falsifier: a non-increasing ratchet on files naming GGUF_TYPE_* or matching a bare integer qtype in this directory (baseline 3, measured on a672677f4); adding a new raw-u32 match → RED. Qwen2.5-Coder tok/s within APR-PERF-GATE-001 on the merge sha, same host.

Ĵ: 24 turns [A] — borrowed; estimate.sh aprender pools 0 of 47 ledger rows today, so there is no measured basis.
Plan + evidence: #3427 · design discussion: #3418

🤖 Generated with Claude Code

Activity

  1. added this to the 0.70.0 milestone on Sep 17, 2026
  2. noahgift commented on Sep 17, 2026

    @noahgift
    MemberAuthor

    Closed as a duplicate of Phase 2 in #3423 (operator decision 2026-09-17: Alfredo's tickets win on duplicates). The per-directory measurements in this ticket's body are mapped onto #3423's Phase 2 in a comment on #3421; the file:line table is in the PMAT-3427 receipt (PR #3447).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Medium priorityenhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions