Skip to content

Correct setup-python and checkout version comments - #156

Merged
PhiLily merged 2 commits into
mainfrom
ci/pin-version-comments
Oct 28, 2026
Merged

PhiLily merged 2 commits into
mainfrom
ci/pin-version-comments

Conversation

@PhiLily

@PhiLily PhiLily commented Oct 27, 2026

Copy link
Copy Markdown
Member

Comments only, in ci.yml, release.yml and security.yml. The 20 actions/setup-python comments go from # v7 to # v7.0.0 and the 25 actions/checkout comments from # v7 to # v7.0.1, so each matches the commit it pins. No hashes or workflow behaviour change, so every workflow runs the same action code as before.

Upstream released setup-python v7.1.0 on 2026-10-22 and moved the floating v7 tag to it, so the v7 comments no longer matched the pinned v7.0.0 commit. The ref-version-mismatch audit flagged all 20 lines, which failed the zizmor online audits job in the Security workflow on main and on every pull request. The checkout comments are not flagged yet, since checkout's v7 still points at v7.0.1, but they would be the day that tag moves.

Run locally with the job's flags, zizmor 1.30.1 reports no findings on this branch.

Set the 20 setup-python comments to v7.0.0 and the 25 checkout comments
to v7.0.1 so each matches the commit it pins. No hashes or workflow
behaviour change. Every workflow runs the same action code as before.

Upstream released setup-python v7.1.0 on 2026-10-22 and moved the
floating v7 tag to it, so the v7 comments no longer matched the pinned
v7.0.0 commit. The ref-version-mismatch audit flagged all 20 lines,
which failed the zizmor online audits job in the Security workflow on
main and on every pull request. The checkout comments are not flagged
yet, since checkout's v7 still points at v7.0.1, but they would be the
day that tag moves.
@PhiLily
PhiLily merged commit b9c0438 into main Oct 28, 2026
58 checks passed
@PhiLily
PhiLily deleted the ci/pin-version-comments branch October 28, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant