falcon-lab: validate npuvm checksum#820
Merged
Merged
Conversation
Before using the downloaded npuvm, we should validate its checksum. This ensures that in cases where the download fails or results in a corrupted file, we can fail early instead of waiting for later test logic to detect the issue (e.g. timeouts in wait_for_dpd()). Signed-off-by: Trey Aspelund <trey@oxidecomputer.com>
taspelund
force-pushed
the
trey/falcon-checksum
branch
from
b035fe7 to
96269a6
Compare
Contributor
Author
|
Tested with a temp commit to corrupt the npuvm file in order to force the retry logic to be exercised, which worked correctly. The temp commit has since been removed. Logs from run w/ temp commit: |
rcgoodfellow
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
falcon-lab: validate npuvm checksum
Before using the downloaded npuvm, we should validate its checksum.
This ensures that in cases where the download fails or results in a
corrupted file, we can fail early instead of waiting for later test
logic to detect the issue (e.g. timeouts in wait_for_dpd()).
Signed-off-by: Trey Aspelund trey@oxidecomputer.com