expose PMBus device info from build-i2c codegen; set IS_PMBUS

build/i2c/src/lib.rs

@@ -1782,6 +1782,27 @@ pub struct I2cDeviceDescription {
     pub sensors: Vec<DeviceSensor>,
     pub device_id: Option<String>,
     pub name: Option<String>,
+    /// If this is a PMBus device, this field contains additional data about the
+    /// PMBus device to be used for generating PMBus-y code.
+    pub pmbus: Option<PmbusDeviceDescription>,
+}
+
+#[derive(Debug, Clone)]
+pub struct PmbusDeviceDescription {
+    pub rails: Vec<PmbusRailDescription>,
+}
+
+#[derive(Debug, Clone)]
+pub struct PmbusRailDescription {
+    pub name: String,
+    pub phases: Vec<u8>,
+}
+
+impl I2cDeviceDescription {
+    /// Returns `true` if this device is a PMBus device.
+    pub fn is_pmbus(&self) -> bool {
+        self.pmbus.is_some()
+    }
 }
 
 ///
@@ -1801,12 +1822,59 @@ pub fn device_descriptions() -> impl Iterator<Item = I2cDeviceDescription> {
     g.devices.into_iter().zip(sensors.device_sensors).map(
         |(device, sensors)| {
             let device_id = device.refdes.as_ref().map(Refdes::to_component_id);
+            let pmbus = device.power.as_ref().and_then(|power| {
+                if !power.pmbus {
+                    return None;
+                }
+
+                let rails = match (power.rails.as_ref(), power.phases.as_ref())
+                {
+                    (Some(rails), Some(phases)) => {
+                        assert_eq!(
+                            rails.len(),
+                            phases.len(),
+                            "invalid config: PMBus device {device_id:?}'s \
+                             `power.rails` and  `power.phases` lists are not \
+                             the same length"
+                        );
+                        rails
+                            .iter()
+                            .cloned()
+                            .zip(phases.iter().cloned())
+                            .map(|(name, phases)| PmbusRailDescription {
+                                name,
+                                phases,
+                            })
+                            .collect()
+                    }
+                    (Some(rails), None) => rails
+                        .iter()
+                        .cloned()
+                        .map(|name| PmbusRailDescription {
+                            name,
+                            phases: Vec::new(),
+                        })
+                        .collect(),
+                    (None, Some(_)) => {
+                        panic!(
+                            "invalid config: PMBus device {device_id:?} \
+                            defines a `power.phases` list, but not a \
+                            `power.rails` list"
+                        );
+                    }
+                    (None, None) => Vec::new(),
+                };
+
+                Some(PmbusDeviceDescription { rails })
+            });
+
             I2cDeviceDescription {
                 device: device.device,
                 description: device.description,
                 sensors,
                 device_id,
                 name: device.name,
+                pmbus,
             }
         },
     )

task/control-plane-agent/src/inventory.rs

@@ -123,6 +123,9 @@ impl Inventory {
         };
 
         let mut capabilities = DeviceCapabilities::empty();
+        if device.is_pmbus {
+            capabilities |= DeviceCapabilities::IS_PMBUS;
+        }
         if !device.sensors.is_empty() {
             capabilities |= DeviceCapabilities::HAS_MEASUREMENT_CHANNELS;
         }

task/validate-api/build.rs

@@ -59,12 +59,13 @@ fn write_pub_device_descriptions() -> anyhow::Result<()> {
     let mut id2idx = std::collections::BTreeMap::new();
 
     for (idx, dev) in devices.into_iter().enumerate() {
+        let is_pmbus = dev.is_pmbus();
         writeln!(file, "    DeviceDescription {{")?;
         writeln!(file, "        device: {:?},", dev.device)?;
         writeln!(file, "        description: {:?},", dev.description)?;
         if let Some(id) = dev.device_id {
             if let Ok(component) = SpComponent::try_from(id.as_ref()) {
-                write!(file, "        id: {:?},", component.id)?;
+                writeln!(file, "        id: {:?},", component.id)?;
                 if id2idx.insert(component.id, idx).is_some() {
                     println!("cargo::error=duplicate device id {id:?}",);
                     duplicate_ids += 1;
@@ -83,6 +84,7 @@ fn write_pub_device_descriptions() -> anyhow::Result<()> {
             );
             missing_ids += 1;
         };
+        writeln!(file, "        is_pmbus: {is_pmbus:?},")?;
         writeln!(file, "        sensors: &[")?;
         for s in dev.sensors {
             writeln!(file, "            SensorDescription {{")?;

task/validate-api/src/lib.rs

@@ -75,6 +75,7 @@ pub struct DeviceDescription {
     pub description: &'static str,
     pub sensors: &'static [SensorDescription],
     pub id: [u8; MAX_ID_LENGTH],
+    pub is_pmbus: bool,
 }
 
 include!(concat!(env!("OUT_DIR"), "/device_descriptions.rs"));