🐛 Follow grapher's chart column renames for the ETL layer - #6765
Conversation
owid/owid-grapher#6826 renamed charts.configIdETL to charts.patchConfigIdETL (an authored layer, like charts.patchConfigId and variables.patchConfigIdETL) and charts.catalogPath to charts.etlConfigCatalogPath (the step that owns the ETL layer, not an identifier). Rename the ORM columns and every read of them in chart-diff, chart-sync and the chart-config-id CLI, and check for the new names when probing whether production has the columns yet. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Quick links (staging server):
Login: chart-diff: ✅No charts for review.data-diff: ✅ no differencesNo differences found. Automatically updated datasets matching excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included. Run locally with Edited: 2026-08-26 17:50:05 UTC |
|
@codex review |
There was a problem hiding this comment.
Pull request overview
Updates ETL to follow the renamed Grapher chart columns, preserving chart diffing, synchronization, and config lookup compatibility.
Changes:
- Renames ORM fields and all chart-related references.
- Updates schema capability detection and tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
etl/grapher/model.py |
Maps the renamed Grapher columns. |
apps/wizard/app_pages/chart_diff/chart_diff.py |
Uses renamed fields for matching and schema detection. |
apps/chart_sync/cli.py |
Reads the renamed ETL catalog path. |
apps/chart_config_id/cli.py |
Updates compatibility documentation. |
tests/apps/wizard/app_pages/chart_diff/test_chart_diff.py |
Updates chart test fixtures. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Stacked on #6511 "Charts as first-class citizens in ETL, addressed by chart config UUID". One commit, no behaviour change.
owid/owid-grapher#6826 "ETL-authored chart configs, addressed by chart config UUID" renamed two columns of the
chartstable after the ETL branch was last refreshed:charts.configIdETL→charts.patchConfigIdETL(an authored layer, likecharts.patchConfigIdandvariables.patchConfigIdETL)charts.catalogPath→charts.etlConfigCatalogPath(the step that owns the ETL layer; not an identifier)Without this, the ETL branch cannot load a chart from a grapher running that PR: chart-diff fails with
Unknown column 'charts.configIdETL'as soon as a chart is listed (observed onstaging-site-chart-diff-layers).This renames the ORM columns and every read of them in chart-diff, chart-sync and
etl chart-config-id, and makes the probe that checks whether production already has the columns look for the new names.Test plan
make checkclean.🤖 Generated with Claude Code