🎨 feat: Required --type option when running install-completion command - #12
Merged
Merged
Conversation
This changes introduces the fact that when the user wants to create a shell completion script s/he needs to specify --type option to specify the shell. This simplifies function that creates completion script. Tests have been added.
emmanuel-quevillon-outscale
requested a review
from anton-kutin
as a code owner
August 19, 2025 09:58
emmanuel-quevillon-outscale
requested review from
anton-kutin,
outscale-rce and
outscale-ykr
and removed request for
anton-kutin
August 19, 2025 09:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes introduces the fact that when the user wants to create a shell completion script s/he needs to specify
--typeoption to specify the shell. This simplifies function that creates completion script. Tests have been added.