Skip to content

✨ feat: add new shortcut - #11

Merged
outscale-ykr merged 6 commits into
mainfrom
feat/Add_new_shortcut
Aug 27, 2025
Merged

outscale-ykr merged 6 commits into
mainfrom
feat/Add_new_shortcut

Conversation

@outscale-rde

Copy link
Copy Markdown
Contributor

No description provided.

@outscale-rde
outscale-rde force-pushed the feat/Add_new_shortcut branch from 52a2e1e to 47bb13b Compare August 14, 2025 08:28
@outscale-ykr
outscale-ykr self-requested a review August 14, 2025 08:42
@outscale-rde
outscale-rde force-pushed the feat/Add_new_shortcut branch from 47bb13b to 269789c Compare August 14, 2025 08:42
@outscale-rde
outscale-rde force-pushed the feat/Add_new_shortcut branch from 269789c to 7734338 Compare August 14, 2025 08:46

@anton-kutin anton-kutin left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this task is ok for me

Signed-off-by: Romain Demeure <romain.demeure@outscale.com>
@emmanuel-quevillon-outscale

emmanuel-quevillon-outscale commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

Hey
Don't want to be annoying guy but for me these new shortcuts could disturb users, at least for me it is a bit distubing.
Example in cache subcommand, -pr for me is like I concatenated -p and -r options in one.
Still in cache when running kubeconfig subcommand, --name (which is the new shortcut) could also apply to project ? Why --name should only be linked to --cluster-name option?
For me, one letter option should stay one letter option and should not become a 2 letter option, unless you concatenate one letter options together (e.g: grep -r -i => grep -ri).
Regarding cluster update, I would suggest --admin-whitelist instead of -a, from my point of view it is clearer that --admin or -a ?
One last remark, when I see -pr option, to me it could resolve to project or profile as they both start with pr which is a bit confusing?
These are my feelings, but I'm not the one who can decided and approve this MR.
Available to discuss about it of course :)

@outscale-ykr
outscale-ykr merged commit 536a5a5 into main Aug 27, 2025
3 checks passed
@outscale-ykr
outscale-ykr deleted the feat/Add_new_shortcut branch August 27, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants