Skip to content

Restyle and harden the tmux help dialog - #7

Merged
gocanto merged 3 commits into
chore/pane-navigation-hintsfrom
chore/ollin-tmux-help-dialog
Jul 21, 2026
Merged

gocanto merged 3 commits into
chore/pane-navigation-hintsfrom
chore/ollin-tmux-help-dialog

Conversation

@gocanto

@gocanto gocanto commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • restyle the tmux binding reference with the requested dark palette, hierarchy, aligned shortcuts, close badge, and truthful footer
  • render fixed-width ANSI rows through focused immutable classes with visible-width truncation, full background fill, and safe resets
  • close only for standalone Escape, Ctrl+C, or exact legacy Esc+t; arrows and unrelated Alt sequences remain open
  • increase the popup to 84x30 and preserve a footer plus resize warning at constrained heights

Verification

  • focused tmux tests (8 passed)
  • make format-all
  • vp run ready (92 passed)
  • pnpm audit --audit-level high
  • render smoke and independent 84x30 geometry/palette/reset review
  • git diff --check
  • exact scope and architecture-policy review

Stack

Base: chore/ollin-pane-lookup-errors / PR #6

Merge this PR only after PR #6.

@gocanto
gocanto marked this pull request as ready for review July 21, 2026 09:19

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the tmux keybindings plugin to support rich ANSI styling and colors. It introduces several new classes under presentation/terminal (DialogPalette, StyledSegment, and TerminalLine) to handle structured rendering, and updates the tests to verify the styled output. Feedback was provided on terminal-line.ts to refactor the color parsing logic (red, green, and blue methods) into a single, robust helper function to prevent potential NaN values and deduplicate code.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread plugins/tmux-keybindings/src/presentation/terminal/terminal-line.ts
Base automatically changed from chore/ollin-pane-lookup-errors to chore/pane-navigation-hints July 21, 2026 09:24
@gocanto
gocanto merged commit b1431ac into chore/pane-navigation-hints Jul 21, 2026
1 check failed
@gocanto
gocanto deleted the chore/ollin-tmux-help-dialog branch July 21, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant