Skip to content

Add pane navigation hints plugin - #5

Merged
gocanto merged 18 commits into
mainfrom
chore/pane-navigation-hints
Jul 21, 2026
Merged

gocanto merged 18 commits into
mainfrom
chore/pane-navigation-hints

Conversation

@gocanto

@gocanto gocanto commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a standalone Pane Navigation Hints plugin that shows effective pane navigation shortcuts in every Herdr pane border
  • read the active [keys] configuration, compact repeated prefixes, omit unbound actions, and stay within Herdr's 80-character title limit
  • refresh existing panes, decorate future panes through pane.created, and clear only the plugin's source-scoped metadata
  • extend the private plugin core pane client with pane listing and typed source-scoped title reporting
  • bump @oullin/herdr-plugin-core to 0.1.1 and document the new plugin in the catalogue

Impact

Users can see the directional, next/previous, and last-pane shortcuts before navigating. The plugin is display-only and remains independent of the tmux keybinding plugin. Clearing it restores normal pane titles without touching manual names or metadata owned by other sources.

Validation

  • make format-all
  • vp install --frozen-lockfile
  • vp run ready — 23 test files and 78 tests passed
  • linked against Herdr 0.7.4 and refreshed 10 existing panes
  • verified a temporary split received the title through the pane.created hook
  • verified clear restored the normal title, removed the temporary pane, and refreshed the live session again

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the pane-navigation-hints plugin to display live pane navigation shortcuts in Herdr pane borders, alongside supporting client updates in @oullin/herdr-plugin-core. The review feedback identifies several key areas for improvement: resolving formatting issues (such as leading + signs) when the prefix keybinding is empty, ensuring cross-platform compatibility when parsing configuration files on Windows, and preventing parsing bugs when handling single-character quoted values.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread plugins/pane-navigation-hints/src/infrastructure/keybinding-config-parser.ts Outdated
Comment thread plugins/pane-navigation-hints/src/infrastructure/keybinding-config-parser.ts Outdated
@gocanto
gocanto marked this pull request as ready for review July 21, 2026 06:51
@gocanto
gocanto marked this pull request as draft July 21, 2026 08:00
@gocanto
gocanto marked this pull request as ready for review July 21, 2026 09:36
@gocanto
gocanto merged commit b3c7373 into main Jul 21, 2026
1 check passed
@gocanto
gocanto deleted the chore/pane-navigation-hints branch July 21, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant