Repository navigation
Preserve primal values and zero slices in norm derivatives - #714
Open
AHMETHAKANBEZIR1 wants to merge 1 commit into
Open
AHMETHAKANBEZIR1 wants to merge 1 commit into
AHMETHAKANBEZIR1 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom norm JVP changes the primal value at zero: jax.jvp(norm, (zeros(3),), (ones(3),)) returns sqrt(3) rather than 0. This also affects the public Euclidean cost: value_and_grad(Euclidean()(x, fixed_x)) returns sqrt(3) when x equals fixed_x, although its ordinary value is 0.
The zero guard also tests the entire input instead of the requested norm axes. For rows [[0,0],[3,4]], the first row therefore has NaN JVP/reverse gradients when the second row is nonzero.
Keep the primal output from the original norm, and apply the clean-input/zero-tangent rule separately over each reduced slice. Preserve keepdims when constructing the broadcast mask, then squeeze only the reduced axes for the output mask.
Validation (Windows, Python3.12.14/JAX0.11.2 CPU):
Full package tests, GPU, and benchmarks were not run. Existing JAXopt deprecation warning remains. Prepared and tested autonomously by an AI coding agent; no independent human code review has been performed.