Skip to content

Fix AV network sky-frame inverse mapping - #372

Merged
oshaughn merged 1 commit into
rift_O4dfrom
fix/av-sky-frame-inverse-o4d
Sep 23, 2026
Merged

oshaughn merged 1 commit into
rift_O4dfrom
fix/av-sky-frame-inverse-o4d

Conversation

@oshaughnessy-junior

Copy link
Copy Markdown
Owner

Summary

Fix --internal-sky-network-coordinates in batch AV by mapping sampled network-frame sky angles back to physical equatorial coordinates with the inverse frame before likelihood evaluation and XML serialization.

Previously the driver reused the forward physical-to-network frame in both places. That applies the same rotation twice rather than undoing it, so the Cartesian AV coordinates were not the intended detector-baseline coordinates.

This change also adds explicitly named physical-to-network and network-to-physical helpers to make the direction unambiguous.

Regression coverage

  • Check that physical-to-network conversion gives cos(theta_HL) = n dot baseline at a fixed epoch.
  • Check that network-to-physical conversion round-trips two representative sky directions.
  • The batch driver now calls the tested network-to-physical helper for both likelihood evaluation and CPU/XML export.

Validation

On citlogin6 in the IGWN Python environment:

2 passed, 4 warnings in 2.58s

The warnings are the pre-existing NumPy matrix deprecation from assign_sky_frame.

Found while diagnosing S250114ax AV sky sampling; this PR changes only the coordinate mapping, not the likelihood or sky prior.

@oshaughnessy-junior
oshaughnessy-junior deployed to private-review-dispatch-rift September 20, 2026 09:44 — with GitHub Actions Active
@oshaughnessy-junior
oshaughnessy-junior force-pushed the fix/av-sky-frame-inverse-o4d branch from 62f2549 to fa67aa5 Compare September 20, 2026 09:46
@oshaughnessy-junior
oshaughnessy-junior deployed to private-review-dispatch-rift September 20, 2026 09:47 — with GitHub Actions Active

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent automated review completed at the recorded exact commit. Detailed findings were withheld from public output by the private-context egress policy and require private human declassification.

@oshaughn
oshaughn merged commit 29da370 into rift_O4d Sep 23, 2026
35 checks passed
@oshaughn
oshaughn deployed to private-review-dispatch-rift September 23, 2026 19:56 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
private-review-dispatch-rift — fa67aa5b Deployed Sep 23, 2026 by oshaughn via Dispatch exact RIFT PR generation #1433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants