Fix AV network sky-frame inverse mapping - #372
Merged
Merged
Conversation
oshaughnessy-junior
deployed
to
private-review-dispatch-rift
September 20, 2026 09:44 — with
GitHub Actions
Active
oshaughnessy-junior
force-pushed
the
fix/av-sky-frame-inverse-o4d
branch
from
September 20, 2026 09:46
62f2549 to
fa67aa5
Compare
oshaughnessy-junior
deployed
to
private-review-dispatch-rift
September 20, 2026 09:47 — with
GitHub Actions
Active
oshaughn
deployed
to
private-review-dispatch-rift
September 23, 2026 19:56 — with
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
--internal-sky-network-coordinatesin batch AV by mapping sampled network-frame sky angles back to physical equatorial coordinates with the inverse frame before likelihood evaluation and XML serialization.Previously the driver reused the forward physical-to-network frame in both places. That applies the same rotation twice rather than undoing it, so the Cartesian AV coordinates were not the intended detector-baseline coordinates.
This change also adds explicitly named physical-to-network and network-to-physical helpers to make the direction unambiguous.
Regression coverage
cos(theta_HL) = n dot baselineat a fixed epoch.Validation
On
citlogin6in the IGWN Python environment:The warnings are the pre-existing NumPy
matrixdeprecation fromassign_sky_frame.Found while diagnosing S250114ax AV sky sampling; this PR changes only the coordinate mapping, not the likelihood or sky prior.