Conversation
oshaughnessy-junior
deployed
to
private-review-dispatch-rift-upstream
September 26, 2026 18:01 — with
GitHub Actions
Active
oshaughnessy-junior
deployed
to
private-review-dispatch-rift-upstream
September 26, 2026 18:18 — with
GitHub Actions
Active
oshaughn
deployed
to
private-review-dispatch-rift-upstream
September 26, 2026 18:19 — with
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPU container-universe ILE and CALPILOT jobs on
rift_O4cput full URLs insidecontainer_image. HTCondor truncates that selector before match-time expansion, which can hold every worker. This ports the basename-plus-URL-transfer fix from #165 and pinsMY.TransferInputto avoid a spurious basename input.CPU ILE and CALPILOT now use a literal fallback image with no GPU-dependent transfer expression. CPU ILE keeps
--gpu --force-xpy --vectorizedfor the NoLoop likelihood path; these executable options are independent of requesting a physical GPU. CPU calibration reweighting resolves a manifest to its fallback instead of trying to launch the YAML as an image, matching #164's calibration fix. GPU families with local/CVMFS entries fail during generation with actionable guidance.Validation outside GitHub CI
condor_submit -dry-runcases covering list/string/empty-string ILE inputs and CPU/GPU ILE/CALPILOT ads.git diff --checkpasses.Independent adversarial review found that string-valued
transfer_filesconcatenated the image selector directly onto a filename. The follow-up commit adds the missing comma and tests that the selector is a distinct transfer item. Independent re-review passed ataeb426d7d1df93fa46ec2d07a440c4ede87c4eb4, with ten additional real HTCondor dry-run cases covering CPU/GPU jobs and list, single-file string, multiple-file string, empty-string, and empty-list inputs. No remaining blocker was found in this PR delta.Scope
This fixes image delivery and CPU fallback selection without changing likelihood code or normalization. Separate adversarial findings remain: shared selectors do not enforce capability upper bounds, and the optional runtime wrapper added in #164 can select by the first physical GPU instead of the assigned GPU. O4c does not implement that wrapper. The deployment checks above do not validate those behaviors.