Added functions to compare multiple LCZ workflows - #38
Merged
Conversation
JOSS paper added to ReadMe
# Conflicts: # DESCRIPTION # NAMESPACE # R/compareLCZ.R # R/compareMultipleLCZ.R # R/confidSensib.R # R/createIntersect.R # R/importLCZvect.R # R/matConfLCZ.R # R/shinyGC/createIntersect.R # man/compareLCZ.Rd # man/compareMultipleLCZ.Rd
To deal with later
…meter but still is the target
…ion of multiple comparison
… consistent concatenateAllLocationsAllWfs therefore renamed loadConcatAllLocationsAllWfs
…ursive trick that may be cleaner with 2 different functions
…ursive trick that may be cleaner with 2 different functions
…risons' into afterMultipleComparisons # Conflicts: # vignettes/lczexplore_multiple_workflows.Rmd
Run R CMD check --no-build-vignettes --no-vignettes after a push
Trying to deport package testing on github actions
…risons' into afterMultipleComparisons # Conflicts: # R/fetchLCZ.R # inst/tinytest/test_importLCZraster.R # inst/tinytest/test_importLCZvect.R # inst/tinytest/test_importQualVar.R # man/fetchLCZ.Rd # tests/tinytest.R
Eleventh fix on action
ebocher
reviewed
May 15, 2026
| name: RCheck | ||
| on: | ||
| push: | ||
| branches: [ afterMultipleComparisons, master ] |
Member
There was a problem hiding this comment.
afterMultipleComparisons to be removed ?
| push: | ||
| branches: [ afterMultipleComparisons, master ] | ||
| pull_request: | ||
| branches: [ afterMultipleComparisons, master ] |
Collaborator
Author
There was a problem hiding this comment.
All .idea folder now "gitignored."
Added a visualisation in PR description.
Some examples and tests to add for chord diagrams, they will be updated along the writing of the vignette.
| # expect_message(fetchLCZ(location="Redon", | ||
| # outDir=system.file("extdata", package = "lczexplore"), | ||
| # wf="bdtopo_2_2"), "The folder already exists.") | ||
| # expect_message(fetchLCZ(location="Redon", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load, intersect, concatenate and visualize multiple workflows.
Added a sankey visualization
TODO :
Examples for drawChordDiagrams
Tests on multiple comparison
Vignette for multiple comparison workflow (as it is not straightforward).