fix(bridge): clean up resources when initialization fails - #33
Open
forever-ivy wants to merge 1 commit into
Open
forever-ivy wants to merge 1 commit into
forever-ivy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Release the MCP connection and any registered page tools when
createWebMcpBridge()fails during its initial tool synchronization.Why
Once the MCP connection succeeds, a failing
tools/listrequest currently rejects initialization without closing the client. IfonRegisterErrorthrows after earlier tools were registered, those registrations also remain active. The caller never receives a bridge instance, so it cannot clean up either resource.Reuse the existing idempotent close behavior for both explicit closure and failed initialization. Cleanup aborts registrations before closing the client, and a cleanup failure does not replace the original initialization error.
Checks
npm run check && npm run lint && npm run typecheck && npm test(16 bridge tests and 17 verify tests).verify:packcheck.