[AI-FSSDK] [FSSDK-12760] Add localHoldouts datafile section#400
Open
jaeopt wants to merge 1 commit into
Open
Conversation
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new top-level
localHoldoutssection to the datafile and updatesDatafileProjectConfigto treat section membership as the sole signal for holdout scope. Entries inholdoutsare global; entries inlocalHoldoutsare rule-scoped viaincludedRules.Changes
lib/optimizely/config/datafile_project_config.rblocalHoldoutsarray; exposelocal_holdoutsattribute.holdoutsare treated as global; anyincludedRulesfield on those entries is stripped at parse time so it cannot narrow scope.includedRulesarray are logged atERRORand excluded from evaluation (no fallback to global).holdout_global?docstring to reflect section-based scoping.lib/optimizely/helpers/constants.rblocalHoldoutsto the datafile JSON schema (mirrorsholdoutsshape).spec/spec_params.rbholdout_local_1,holdout_local_2) into the new top-levellocalHoldoutssection. Removed the invalid empty-includedRulesfixture (now logged + skipped per spec).spec/config/datafile_project_config_spec.rblocal_holdoutsin tandem withholdoutsfor counts.includedRuleson global entries, invalid local holdouts (missing/emptyincludedRules), backward compatibility with datafiles that have nolocalHoldoutssection.Backward Compatibility
Older SDKs ignore the unknown
localHoldoutskey entirely; only the globalholdoutssection is parsed. Gen 3 SDKs now read both sections with a hard partition. No deserializer risk, no schema enum changes, no log spam.Jira Ticket
FSSDK-12760